Merge pull request #19668 from overleaf/jpa-file-not-found-404

[web] entity not found when downloading file yields 404 GitOrigin-RevId: e6a2a7cf60f717fae53a42f39efb65f1624f71bb
2024-08-05 08:04:08 +00:00
parent 603ff28df0
commit 0f2aaa6c0c
2 changed files with 14 additions and 2 deletions
@@ -15,18 +15,21 @@ module.exports = {
      { project_id: projectId, element_id: fileId, type: 'file' },
      function (err, file) {
        if (err) {
-          if (err.name === 'NotFoundError') {
+          if (err instanceof Errors.NotFoundError) {
            logger.warn(
              { err, projectId, fileId, queryString },
              'entity not found when downloading file'
            )
+            // res.sendStatus() sends a description of the status as body.
+            // Using res.status().end() avoids sending that fake body.
+            return res.status(404).end()
          } else {
            logger.err(
              { err, projectId, fileId, queryString },
              'error finding element for downloading file'
            )
+            return res.status(500).end()
          }
-          return res.sendStatus(500)
        }
        FileStoreHandler.getFileStream(
          projectId,