From 0b387c511631880015b3539c6ef47bd4dfff1b90 Mon Sep 17 00:00:00 2001
From: Andrew Rumble <andrew.rumble@overleaf.com>
Date: Tue, 11 Mar 2025 10:29:14 +0000
Subject: [PATCH] Simplify error identification

GitOrigin-RevId: 6dae1ed99269deb26e15ec921ba173f85f5e6fc9
---
 .../backupVerifier/ProjectVerifier.mjs        | 26 +++----------------
 1 file changed, 4 insertions(+), 22 deletions(-)

diff --git a/services/history-v1/backupVerifier/ProjectVerifier.mjs b/services/history-v1/backupVerifier/ProjectVerifier.mjs
index 33887de805..8555d64f77 100644
--- a/services/history-v1/backupVerifier/ProjectVerifier.mjs
+++ b/services/history-v1/backupVerifier/ProjectVerifier.mjs
@@ -40,31 +40,13 @@ export function setWriteMetrics(writeMetrics) {
  * @param {string} historyId
  */
 function handleVerificationError(error, historyId) {
-  let errorType = 'unknown'
-  // Additional detail for verbose/development
-  if (error instanceof Error) {
-    if (error instanceof BackupCorruptedInvalidBlobError) {
-      errorType = 'invalid-blob'
-    } else if (error instanceof BackupCorruptedMissingBlobError) {
-      errorType = 'missing-blob'
-    } else if (error instanceof BackupCorruptedError) {
-      errorType = 'backup-corrupted-unknown'
-    } else if (error instanceof BackupRPOViolationChunkNotBackedUpError) {
-      errorType = 'rpo-violation-chunk-not-backed-up'
-    } else if (error instanceof BackupRPOViolationError) {
-      errorType = 'rpo-violation'
-    }
-  }
-
-  logger.error(
-    { errorType, historyId, error },
-    'error verifying project backup'
-  )
+  const name = error instanceof Error ? error.name : 'UnknownError'
+  logger.error({ historyId, error, name }, 'error verifying project backup')
 
   WRITE_METRICS &&
-    metrics.inc(METRICS.backup_project_verification_failed, 1, { errorType })
+    metrics.inc(METRICS.backup_project_verification_failed, 1, { name })
 
-  return errorType
+  return name
 }
 
 /**