mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 18:50:55 +00:00
4470c3d58a
## Description: The **proximityBonusPortsNb** function increased the likelihood a tradeship would go to a nearby port. But now that trade gold is nerfed from nearby ports, we shouldn't encourage trading with ports that are too close. So now add another factor **tradeShipShortRangeDebuff** That cancels out the proximity bonus if the port is too close. Now tradeships are encouraged to go to ports that are close, but not too close. Also move tradingPorts method to the PortExecution class because that's the only place it's used. ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: evan
95 lines
2.5 KiB
TypeScript
95 lines
2.5 KiB
TypeScript
import {
|
|
Game,
|
|
Player,
|
|
PlayerInfo,
|
|
PlayerType,
|
|
UnitType,
|
|
} from "../src/core/game/Game";
|
|
import { setup } from "./util/Setup";
|
|
|
|
let game: Game;
|
|
let player: Player;
|
|
let other: Player;
|
|
|
|
describe("PlayerImpl", () => {
|
|
beforeEach(async () => {
|
|
game = await setup(
|
|
"plains",
|
|
{
|
|
instantBuild: true,
|
|
},
|
|
[
|
|
new PlayerInfo("player", PlayerType.Human, null, "player_id"),
|
|
new PlayerInfo("other", PlayerType.Human, null, "other_id"),
|
|
],
|
|
);
|
|
|
|
while (game.inSpawnPhase()) {
|
|
game.executeNextTick();
|
|
}
|
|
|
|
player = game.player("player_id");
|
|
player.addGold(BigInt(1000000));
|
|
other = game.player("other_id");
|
|
|
|
game.config().structureMinDist = () => 10;
|
|
});
|
|
|
|
test("City can be upgraded", () => {
|
|
const city = player.buildUnit(UnitType.City, game.ref(0, 0), {});
|
|
const buCity = player
|
|
.buildableUnits(game.ref(0, 0))
|
|
.find((bu) => bu.type === UnitType.City);
|
|
expect(buCity).toBeDefined();
|
|
expect(buCity!.canUpgrade).toBe(city.id());
|
|
});
|
|
|
|
test("DefensePost cannot be upgraded", () => {
|
|
player.buildUnit(UnitType.DefensePost, game.ref(0, 0), {});
|
|
const buDefensePost = player
|
|
.buildableUnits(game.ref(0, 0))
|
|
.find((bu) => bu.type === UnitType.DefensePost);
|
|
expect(buDefensePost).toBeDefined();
|
|
expect(buDefensePost!.canUpgrade).toBeFalsy();
|
|
});
|
|
|
|
test("City can be upgraded from another city", () => {
|
|
const city = player.buildUnit(UnitType.City, game.ref(0, 0), {});
|
|
const cityToUpgrade = player.findUnitToUpgrade(
|
|
UnitType.City,
|
|
game.ref(0, 1),
|
|
);
|
|
expect(cityToUpgrade).toBeTruthy();
|
|
if (cityToUpgrade === false) {
|
|
return;
|
|
}
|
|
expect(cityToUpgrade.id()).toBe(city.id());
|
|
});
|
|
test("City cannot be upgraded when too far away", () => {
|
|
player.buildUnit(UnitType.City, game.ref(0, 0), {});
|
|
const cityToUpgrade = player.findUnitToUpgrade(
|
|
UnitType.City,
|
|
game.ref(50, 50),
|
|
);
|
|
expect(cityToUpgrade).toBe(false);
|
|
});
|
|
test("Unit cannot be upgraded when not enough gold", () => {
|
|
player.buildUnit(UnitType.City, game.ref(0, 0), {});
|
|
player.removeGold(BigInt(1000000));
|
|
const cityToUpgrade = player.findUnitToUpgrade(
|
|
UnitType.City,
|
|
game.ref(0, 1),
|
|
);
|
|
expect(cityToUpgrade).toBe(false);
|
|
});
|
|
|
|
test("Can't send alliance requests when dead", () => {
|
|
// conquer other
|
|
const otherTiles = other.tiles();
|
|
for (const tile of otherTiles) {
|
|
player.conquer(tile);
|
|
}
|
|
expect(other.canSendAllianceRequest(player)).toBe(false);
|
|
});
|
|
});
|