mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-22 17:46:39 +00:00
70745faac4
## Description: Improve type safety and runtime correctness by: 1. Enabling TypeScript's [strictNullChecks](https://www.typescriptlang.org/tsconfig/#strictNullChecks) compiler option. 2. Replacing all loose equality operators (`==` and `!=`) with strict equality operators (`===` and `!==`). 3. Cleaning up of type declarations, null handling logic, and equality expressions throughout the project. Currently, the code allows implicit assumptions that `null` and `undefined` are interchangeable, and relies on type-coercing equality checks that can introduce subtle bugs. These practices make it difficult to reason about when values may be absent and hinder the effectiveness of static analysis. Migrating to strict null checks and enforcing strict equality comparisons will clarify intent, reduce bugs, and make the codebase safer and easier to maintain. Fixes #466 ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [x] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors --------- Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com> Co-authored-by: evanpelle <openfrontio@gmail.com>
120 lines
2.9 KiB
TypeScript
120 lines
2.9 KiB
TypeScript
import { LitElement, css, html } from "lit";
|
|
import { customElement, property } from "lit/decorators.js";
|
|
|
|
declare global {
|
|
interface Window {
|
|
adsbygoogle: unknown[];
|
|
}
|
|
}
|
|
|
|
/**
|
|
* Google AdSense integration component
|
|
*
|
|
* This component creates a configurable container for Google AdSense ads
|
|
* and properly initializes them after the component is rendered.
|
|
*/
|
|
@customElement("google-ad")
|
|
export class GoogleAdElement extends LitElement {
|
|
// Configurable properties
|
|
@property({ type: String }) adClient = "ca-pub-7035513310742290";
|
|
@property({ type: String }) adSlot = "5220834834";
|
|
@property({ type: String }) adFormat = "auto";
|
|
@property({ type: Boolean }) fullWidthResponsive = true;
|
|
@property({ type: String }) adTest = "off"; // "on" for testing, remove or set to "off" for production
|
|
@property({ type: String }) darkBackgroundColor = "rgba(0, 0, 0, 0.2)";
|
|
|
|
// Disable shadow DOM so AdSense can access the elements
|
|
createRenderRoot() {
|
|
return this;
|
|
}
|
|
|
|
static styles = css`
|
|
.google-ad-container {
|
|
margin-top: 1rem;
|
|
border-radius: 0.5rem;
|
|
padding: 0.5rem;
|
|
width: 100%;
|
|
overflow: hidden;
|
|
transition:
|
|
opacity 0.3s ease,
|
|
height 0.3s ease;
|
|
}
|
|
.google-ad-container.hidden {
|
|
opacity: 0;
|
|
height: 0;
|
|
padding: 0;
|
|
margin: 0;
|
|
overflow: hidden;
|
|
}
|
|
`;
|
|
|
|
render() {
|
|
if (isElectron()) {
|
|
return html``;
|
|
}
|
|
return html`
|
|
<div class="google-ad-container">
|
|
<ins
|
|
class="adsbygoogle"
|
|
style="display:block"
|
|
data-ad-client="${this.adClient}"
|
|
data-ad-slot="${this.adSlot}"
|
|
data-ad-format="${this.adFormat}"
|
|
data-full-width-responsive="${this.fullWidthResponsive}"
|
|
data-adtest="${this.adTest}"
|
|
></ins>
|
|
</div>
|
|
`;
|
|
}
|
|
|
|
connectedCallback() {
|
|
super.connectedCallback();
|
|
|
|
// Wait for the component to be fully rendered
|
|
setTimeout(() => {
|
|
try {
|
|
// Initialize this specific ad
|
|
(window.adsbygoogle = window.adsbygoogle || []).push({});
|
|
console.log("Ad initialized for slot:", this.adSlot);
|
|
} catch (e) {
|
|
console.error("AdSense initialization error for slot:", this.adSlot, e);
|
|
}
|
|
}, 100);
|
|
}
|
|
}
|
|
|
|
// Check if running in Electron
|
|
const isElectron = () => {
|
|
// Renderer process
|
|
if (
|
|
window !== undefined &&
|
|
typeof window.process === "object" &&
|
|
// @ts-expect-error hidden
|
|
window.process.type === "renderer"
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
// Main process
|
|
if (
|
|
process !== undefined &&
|
|
typeof process.versions === "object" &&
|
|
!!process.versions.electron
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
// Detect the user agent when the `nodeIntegration` option is set to false
|
|
if (
|
|
typeof navigator === "object" &&
|
|
typeof navigator.userAgent === "string" &&
|
|
navigator.userAgent.indexOf("Electron") >= 0
|
|
) {
|
|
return true;
|
|
}
|
|
|
|
return false;
|
|
};
|
|
|
|
export default GoogleAdElement;
|