OpenFrontIO/tests/server/MasterLobbyServiceHealth.test.ts

import EventEmitter from "events";
import { describe, expect, it, vi } from "vitest";
import { MasterLobbyService } from "../../src/server/MasterLobbyService";
import { ServerEnv } from "../../src/server/ServerEnv";

vi.mock("../../src/server/Logger", () => ({
  logger: {
    child: () => ({
      error: vi.fn(),
      info: vi.fn(),
    }),
  },
}));

vi.mock("../../src/server/PollingLoop", () => ({
  startPolling: vi.fn(),
}));

function createMockWorker(): EventEmitter {
  const emitter = new EventEmitter();
  (emitter as any).send = vi.fn();
  return emitter;
}

function sendWorkerReady(worker: EventEmitter, workerId: number) {
  worker.emit("message", { type: "workerReady", workerId });
}

function createService(numWorkers: number): MasterLobbyService {
  vi.spyOn(ServerEnv, "numWorkers").mockReturnValue(numWorkers);
  const log = { info: vi.fn(), error: vi.fn() } as any;
  return new MasterLobbyService({} as any, log);
}

function startAllWorkers(
  service: MasterLobbyService,
  count: number,
): { id: number; w: EventEmitter }[] {
  const workers = Array.from({ length: count }, (_, i) => {
    const id = i + 1;
    const w = createMockWorker();
    service.registerWorker(id, w as any);
    return { id, w };
  });
  for (const { w, id } of workers) {
    sendWorkerReady(w, id);
  }
  return workers;
}

describe("MasterLobbyService lobby report validation", () => {
  it("keeps the valid lobbies when a report contains a malformed entry", () => {
    const service = createService(1);
    const [{ w }] = startAllWorkers(service, 1);

    w.emit("message", {
      type: "lobbyList",
      lobbies: [
        // Missing publicGameType, like a matchmaking game reported by
        // mistake. It must be dropped without discarding the whole report.
        { gameID: "bad", numClients: 0 },
        { gameID: "good", numClients: 1, publicGameType: "ffa" },
      ],
    });

    (service as any).broadcastLobbies();

    const broadcast = ((w as any).send as ReturnType<typeof vi.fn>).mock.calls
      .map((c) => c[0])
      .find((m) => m.type === "lobbiesBroadcast");
    expect(broadcast).toBeDefined();
    expect(
      broadcast.publicGames.games.ffa.map((l: { gameID: string }) => l.gameID),
    ).toEqual(["good"]);
  });
});

describe("MasterLobbyService.isHealthy", () => {
  it("unhealthy before any workers register", () => {
    const service = createService(4);
    expect(service.isHealthy()).toBe(false);
  });

  it("unhealthy when workers registered but not ready", () => {
    const service = createService(2);
    service.registerWorker(1, createMockWorker() as any);
    expect(service.isHealthy()).toBe(false);
  });

  it("unhealthy when only some workers are ready (server not started)", () => {
    const service = createService(4);

    // 1 of 4 ready -- not enough to flip `started`
    const w1 = createMockWorker();
    service.registerWorker(1, w1 as any);
    sendWorkerReady(w1, 1);

    expect(service.isHealthy()).toBe(false);
  });

  it("healthy once all workers are ready", () => {
    const service = createService(2);
    startAllWorkers(service, 2);
    expect(service.isHealthy()).toBe(true);
  });

  it("stays healthy after a single worker crash", () => {
    const service = createService(4);
    startAllWorkers(service, 4);

    service.removeWorker(4); // 3 of 4 left, threshold is 2
    expect(service.isHealthy()).toBe(true);
  });

  it("goes unhealthy when too many workers crash", () => {
    const service = createService(4);
    startAllWorkers(service, 4);

    service.removeWorker(2);
    service.removeWorker(3);
    service.removeWorker(4); // 1 of 4 left, threshold is 2
    expect(service.isHealthy()).toBe(false);
  });

  it("single-worker setup goes unhealthy on crash", () => {
    const service = createService(1);
    startAllWorkers(service, 1);
    expect(service.isHealthy()).toBe(true);

    service.removeWorker(1);
    expect(service.isHealthy()).toBe(false);
  });

  it("odd worker count: threshold rounds up (3 workers)", () => {
    const service = createService(3);
    startAllWorkers(service, 3);

    // min = 3/2 = 1.5, so 2 ready is enough, 1 is not
    service.removeWorker(3);
    expect(service.isHealthy()).toBe(true);

    service.removeWorker(2);
    expect(service.isHealthy()).toBe(false);
  });
});