mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-10 18:44:35 +00:00
a7f992e9b0
Restructure the single src/ tree into an npm-workspaces monorepo under
packages/, rename core -> engine, extract a types-only core-public layer,
and break the pre-existing engine -> client dependency cycle.
Structure (packages/):
core-public public API/wire schemas + shared enums (clean leaf)
shared framework-agnostic helpers (clean leaf)
engine deterministic simulation (was src/core)
client rendering/UI (was src/client)
server coordination (was src/server)
Dependency DAG: engine -> {core-public, shared}; client -> {core-public,
shared, engine}; server -> {core-public, engine}.
- npm workspaces: root package.json workspaces + per-package package.json;
tsconfig.base.json holds shared options + path aliases
(core-public/* shared/* engine/* client/* server/*) resolved uniformly by
tsc, Vite (resolve.tsconfigPaths), Vitest, and tsx. Lockfile regenerated.
- core-public: moved Schemas/ApiSchemas/CosmeticSchemas/StatsSchemas/
ClanApiSchemas/WorkerSchemas/Base64/PatternDecoder; extracted the enums
(GameTypes), GameEvent type, emoji table, and GraphicsOverrides schema.
Engine re-exports the moved enums/types so existing imports keep working.
- Broke engine -> client cycle:
- renderNumber/renderTroops -> shared/format
- NameBoxCalculator moved into engine
- username validation returns translation key + params; client translates
- applyStateUpdate moved to client (operates on the render-only PlayerState)
- Config/UnitGrid/execution-Util/GameImpl now use structural read
interfaces (engine/game/ReadViews: PlayerLike/UnitLike/GameLike) instead
of importing client view classes; client imports view classes from a new
client/view barrel; deleted the engine/game/GameView re-export shim.
- Build/deploy updated: vite.config, index.html, eslint, Dockerfile
(copies packages/ + tsconfig.base.json before npm ci), .vscode, tests.
Verified: tsc --noEmit clean; 1364 + 65 tests pass; production vite build
succeeds; engine has zero client/server imports; core-public and shared are
dependency leaves.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
57 lines
1.7 KiB
TypeScript
57 lines
1.7 KiB
TypeScript
import { vi, type MockInstance } from "vitest";
|
|
import { getMessageTypeClasses, severityColors } from "client/Utils";
|
|
import { MessageType } from "engine/game/Game";
|
|
|
|
describe("getMessageTypeClasses", () => {
|
|
// Spy on console.warn to track when the default case is hit
|
|
let consoleSpy: MockInstance;
|
|
|
|
beforeEach(() => {
|
|
consoleSpy = vi.spyOn(console, "warn").mockImplementation(() => {});
|
|
});
|
|
|
|
afterEach(() => {
|
|
consoleSpy.mockRestore();
|
|
});
|
|
|
|
it("should return a valid CSS class for every MessageType", () => {
|
|
const messageTypes = Object.values(MessageType).filter(
|
|
(value): value is MessageType => typeof value === "number",
|
|
);
|
|
|
|
messageTypes.forEach((messageType) => {
|
|
const result = getMessageTypeClasses(messageType);
|
|
|
|
expect(Object.values(severityColors)).toContain(result);
|
|
|
|
expect(result).toBeTruthy();
|
|
expect(typeof result).toBe("string");
|
|
});
|
|
});
|
|
|
|
it("should not trigger console.warn for any MessageType", () => {
|
|
const messageTypes = Object.values(MessageType).filter(
|
|
(value): value is MessageType => typeof value === "number",
|
|
);
|
|
|
|
messageTypes.forEach((messageType) => {
|
|
getMessageTypeClasses(messageType);
|
|
});
|
|
|
|
// No message type should fall through to the default case
|
|
expect(consoleSpy).not.toHaveBeenCalled();
|
|
});
|
|
|
|
it("should return white color and warn for unknown message types", () => {
|
|
// Cast to MessageType to test the default case
|
|
const unknownType = 999 as MessageType;
|
|
|
|
const result = getMessageTypeClasses(unknownType);
|
|
|
|
expect(result).toBe(severityColors["white"]);
|
|
expect(consoleSpy).toHaveBeenCalledWith(
|
|
"Message type 999 has no explicit color",
|
|
);
|
|
});
|
|
});
|