mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-22 08:48:10 +00:00
e1d31ef1ee
If this PR fixes an issue, link it below. If not, delete these two lines. Resolves #2868 ## Description: This PR addresses a critical memory leak in the Master server process (causing ~30GB RAM usage). The issue was caused by `setInterval` calling `fetchLobbies()` every 100ms. When `fetchLobbies` took longer than 100ms to complete (due to network latency or load), requests would pile up indefinitely, creating a massive queue of pending Promises and open sockets. I have refactored the polling logic into a generic `startPolling` utility (in `src/server/PollingLoop.ts`) that uses a recursive `setTimeout` pattern. This ensures that the next `fetchLobbies` call is only scheduled *after* the previous one has completed (successfully or failed), preventing any request pile-up. ## Please complete the following: - [x] I have added screenshots for all UI updates (N/A - backend only) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file (N/A - no user facing text) - [x] I have added relevant tests to the test directory (`tests/PollingLoop.test.ts`) - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: codimo
65 lines
1.9 KiB
TypeScript
65 lines
1.9 KiB
TypeScript
import { base64url } from "jose";
|
|
import { Logger } from "winston";
|
|
import { CosmeticsSchema } from "../core/CosmeticSchemas";
|
|
import { startPolling } from "./PollingLoop";
|
|
import {
|
|
FailOpenPrivilegeChecker,
|
|
PrivilegeChecker,
|
|
PrivilegeCheckerImpl,
|
|
} from "./Privilege";
|
|
|
|
// Refreshes the privilege checker every 5 minutes.
|
|
// WARNING: This fails open if cosmetics.json is not available.
|
|
export class PrivilegeRefresher {
|
|
private privilegeChecker: PrivilegeChecker | null = null;
|
|
private failOpenPrivilegeChecker: PrivilegeChecker =
|
|
new FailOpenPrivilegeChecker();
|
|
|
|
private log: Logger;
|
|
|
|
constructor(
|
|
private endpoint: string,
|
|
parentLog: Logger,
|
|
private refreshInterval: number = 1000 * 60 * 3,
|
|
) {
|
|
this.log = parentLog.child({ comp: "privilege-refresher" });
|
|
}
|
|
|
|
public async start() {
|
|
this.log.info(
|
|
`Starting privilege refresher with interval ${this.refreshInterval}`,
|
|
);
|
|
startPolling(() => this.loadPrivilegeChecker(), this.refreshInterval);
|
|
}
|
|
|
|
public get(): PrivilegeChecker {
|
|
return this.privilegeChecker ?? this.failOpenPrivilegeChecker;
|
|
}
|
|
|
|
private async loadPrivilegeChecker(): Promise<void> {
|
|
this.log.info(`Loading privilege checker from ${this.endpoint}`);
|
|
try {
|
|
const response = await fetch(this.endpoint);
|
|
if (!response.ok) {
|
|
throw new Error(`HTTP error! status: ${response.status}`);
|
|
}
|
|
|
|
const cosmeticsData = await response.json();
|
|
const result = CosmeticsSchema.safeParse(cosmeticsData);
|
|
|
|
if (!result.success) {
|
|
throw new Error(`Invalid cosmetics data: ${result.error.message}`);
|
|
}
|
|
|
|
this.privilegeChecker = new PrivilegeCheckerImpl(
|
|
result.data,
|
|
base64url.decode,
|
|
);
|
|
this.log.info(`Privilege checker loaded successfully`);
|
|
} catch (error) {
|
|
this.log.error(`Failed to fetch cosmetics from ${this.endpoint}:`, error);
|
|
throw error;
|
|
}
|
|
}
|
|
}
|