mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 13:30:43 +00:00
70745faac4
## Description: Improve type safety and runtime correctness by: 1. Enabling TypeScript's [strictNullChecks](https://www.typescriptlang.org/tsconfig/#strictNullChecks) compiler option. 2. Replacing all loose equality operators (`==` and `!=`) with strict equality operators (`===` and `!==`). 3. Cleaning up of type declarations, null handling logic, and equality expressions throughout the project. Currently, the code allows implicit assumptions that `null` and `undefined` are interchangeable, and relies on type-coercing equality checks that can introduce subtle bugs. These practices make it difficult to reason about when values may be absent and hinder the effectiveness of static analysis. Migrating to strict null checks and enforcing strict equality comparisons will clarify intent, reduce bugs, and make the codebase safer and easier to maintain. Fixes #466 ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [x] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors --------- Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com> Co-authored-by: evanpelle <openfrontio@gmail.com>
191 lines
5.6 KiB
TypeScript
191 lines
5.6 KiB
TypeScript
import { LitElement, html } from "lit";
|
|
import { customElement, property, state } from "lit/decorators.js";
|
|
import { GameEnv } from "../../../core/configuration/Config";
|
|
import { GameType } from "../../../core/game/Game";
|
|
import { GameView } from "../../../core/game/GameView";
|
|
import { MultiTabDetector } from "../../MultiTabDetector";
|
|
import { translateText } from "../../Utils";
|
|
import { Layer } from "./Layer";
|
|
|
|
@customElement("multi-tab-modal")
|
|
export class MultiTabModal extends LitElement implements Layer {
|
|
public game: GameView;
|
|
|
|
private detector: MultiTabDetector;
|
|
|
|
@property({ type: Number }) duration: number = 5000;
|
|
@state() private countdown: number = 5;
|
|
@state() private isVisible: boolean = false;
|
|
@state() private fakeIp: string = "";
|
|
@state() private deviceFingerprint: string = "";
|
|
@state() private reported: boolean = true;
|
|
|
|
private intervalId?: number;
|
|
|
|
// Disable shadow DOM to allow Tailwind classes to work
|
|
createRenderRoot() {
|
|
return this;
|
|
}
|
|
|
|
tick() {
|
|
if (
|
|
this.game.inSpawnPhase() ||
|
|
this.game.config().gameConfig().gameType === GameType.Singleplayer ||
|
|
this.game.config().serverConfig().env() === GameEnv.Dev
|
|
) {
|
|
return;
|
|
}
|
|
if (!this.detector) {
|
|
this.detector = new MultiTabDetector();
|
|
this.detector.startMonitoring((duration: number) => {
|
|
this.show(duration);
|
|
});
|
|
}
|
|
}
|
|
|
|
init() {
|
|
this.fakeIp = this.generateFakeIp();
|
|
this.deviceFingerprint = this.generateDeviceFingerprint();
|
|
this.reported = true;
|
|
}
|
|
|
|
// Generate fake IP in format xxx.xxx.xxx.xxx
|
|
private generateFakeIp(): string {
|
|
return Array.from({ length: 4 }, () =>
|
|
Math.floor(Math.random() * 255),
|
|
).join(".");
|
|
}
|
|
|
|
// Generate fake device fingerprint (32 character hex)
|
|
private generateDeviceFingerprint(): string {
|
|
return Array.from({ length: 32 }, () =>
|
|
Math.floor(Math.random() * 16).toString(16),
|
|
).join("");
|
|
}
|
|
|
|
// Show the modal with penalty information
|
|
public show(duration: number): void {
|
|
if (!this.game.myPlayer()?.isAlive()) {
|
|
return;
|
|
}
|
|
this.duration = duration;
|
|
this.countdown = Math.ceil(duration / 1000);
|
|
this.isVisible = true;
|
|
|
|
// Start countdown timer
|
|
this.intervalId = window.setInterval(() => {
|
|
this.countdown--;
|
|
|
|
if (this.countdown <= 0) {
|
|
this.hide();
|
|
}
|
|
}, 1000);
|
|
|
|
this.requestUpdate();
|
|
}
|
|
|
|
// Hide the modal
|
|
public hide(): void {
|
|
this.isVisible = false;
|
|
|
|
if (this.intervalId) {
|
|
window.clearInterval(this.intervalId);
|
|
this.intervalId = undefined;
|
|
}
|
|
|
|
// Dispatch event when modal is closed
|
|
this.dispatchEvent(
|
|
new CustomEvent("penalty-complete", {
|
|
bubbles: true,
|
|
composed: true,
|
|
}),
|
|
);
|
|
|
|
this.requestUpdate();
|
|
}
|
|
|
|
disconnectedCallback() {
|
|
super.disconnectedCallback();
|
|
if (this.intervalId) {
|
|
window.clearInterval(this.intervalId);
|
|
}
|
|
}
|
|
|
|
render() {
|
|
if (!this.isVisible) {
|
|
return html``;
|
|
}
|
|
|
|
return html`
|
|
<div
|
|
class="fixed inset-0 z-50 overflow-auto bg-red-500/20 flex items-center justify-center"
|
|
>
|
|
<div
|
|
class="relative p-6 bg-white dark:bg-gray-800 rounded-xl shadow-xl max-w-md w-full m-4 transition-all transform"
|
|
>
|
|
<div class="flex items-center justify-between mb-4">
|
|
<h2 class="text-2xl font-bold text-red-600 dark:text-red-400">
|
|
${translateText("multi_tab.warning")}
|
|
</h2>
|
|
<div
|
|
class="px-2 py-1 bg-red-600 text-white text-xs font-bold rounded-full animate-pulse"
|
|
>
|
|
RECORDING
|
|
</div>
|
|
</div>
|
|
|
|
<p class="mb-4 text-gray-800 dark:text-gray-200">
|
|
${translateText("multi_tab.detected")}
|
|
</p>
|
|
|
|
<div
|
|
class="mb-4 p-3 bg-gray-100 dark:bg-gray-900 rounded-md text-sm font-mono"
|
|
>
|
|
<div class="flex justify-between mb-1">
|
|
<span class="text-gray-500 dark:text-gray-400">IP:</span>
|
|
<span class="text-red-600 dark:text-red-400">${this.fakeIp}</span>
|
|
</div>
|
|
<div class="flex justify-between mb-1">
|
|
<span class="text-gray-500 dark:text-gray-400"
|
|
>Device Fingerprint:</span
|
|
>
|
|
<span class="text-red-600 dark:text-red-400"
|
|
>${this.deviceFingerprint}</span
|
|
>
|
|
</div>
|
|
<div class="flex justify-between">
|
|
<span class="text-gray-500 dark:text-gray-400">Reported:</span>
|
|
<span class="text-red-600 dark:text-red-400"
|
|
>${this.reported ? "TRUE" : "FALSE"}</span
|
|
>
|
|
</div>
|
|
</div>
|
|
|
|
<p class="mb-4 text-gray-800 dark:text-gray-200">
|
|
${translateText("multi_tab.please_wait")}
|
|
<span class="font-bold text-xl">${this.countdown}</span>
|
|
${translateText("multi_tab.seconds")}
|
|
</p>
|
|
|
|
<div
|
|
class="w-full bg-gray-200 dark:bg-gray-700 rounded-full h-2.5 mb-4"
|
|
>
|
|
<div
|
|
class="bg-red-600 dark:bg-red-500 h-2.5 rounded-full transition-all duration-1000 ease-linear"
|
|
style="width: ${(this.countdown / (this.duration / 1000)) * 100}%"
|
|
></div>
|
|
</div>
|
|
|
|
<p class="text-sm text-gray-600 dark:text-gray-400">
|
|
${translateText("multi_tab.explanation")}
|
|
</p>
|
|
|
|
<p class="mt-3 text-xs text-red-500 font-semibold">
|
|
Repeated violations may result in permanent account suspension.
|
|
</p>
|
|
</div>
|
|
</div>
|
|
`;
|
|
}
|
|
}
|