mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-25 04:22:44 +00:00
Evan
182d008ddd
**Add approved & assigned issue number here:** N/A — maintainer follow-up to #4227. ## Description: Follow-up to #4227, finishing the "info.json is the single source of truth" refactor. **Maps.gen.ts now generates one `MapInfo` interface and a `maps` list** instead of parallel lookup records. `mapCategories`, `mapTranslationKeys`, and `multiplayerFrequency` are gone — consumers read the list directly (`map.categories`, `map.translationKey`, `map.multiplayerFrequency`). MapPicker got simpler in the process: it renders from `MapInfo` objects, so the reverse `Object.entries(GameMapType)` lookup to recover the enum key is gone. The featured-rank sort moved out of the Go codegen into the picker, where the presentation concern belongs. **`SPECIAL_TEAM_MAPS` moves into info.json** as an optional `special_team_count` field (set on the same 17 maps with the same values). MapPlaylist derives its map from the generated list; `SPECIAL_TEAM_FORCE_CHANCE` and the frequency multiplier behavior are unchanged. **The en.json `map` section is now generated.** A new optional `display_name` field in info.json (defaulting to `name`) is written to `resources/lang/en.json` by the generator, preserving the section's non-map UI keys (`map`, `featured`, `all`, `favorites`, `random`). The 8 maps whose English display name intentionally differs from the frozen enum value (e.g. `MENA`, `Milky Way`, `Europe (Classic)`, `Baikal (Nuke Wars)`) declare it via `display_name`, so no display text changes. The section is emitted alphabetically; since #4232 already sorted en.json and every value matches, regeneration is byte-identical and this PR has no en.json diff. Other languages remain Crowdin-managed. The generator also now validates `translation_key` is exactly `map.<folder>` and `special_team_count >= 2`. MapConsistency tests compare info.json directly against the generated list and the en.json section, and fail with a "run `npm run gen-maps`" message on drift. No behavior changes: enum values, playlist frequencies, special-team counts, featured order, and display names are all byte-identical. ## Please complete the following: - [x] I have added screenshots for all UI updates (no UI changes — internal refactor, rendering output identical) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: evanpelle 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
163 lines
3.1 KiB
JSON
163 lines
3.1 KiB
JSON
{
|
|
"id": "GulfOfStLawrence",
|
|
"name": "Gulf of St. Lawrence",
|
|
"translation_key": "map.gulfofstlawrence",
|
|
"categories": ["north_america"],
|
|
"multiplayer_frequency": 4,
|
|
"special_team_count": 3,
|
|
"nations": [
|
|
{
|
|
"coordinates": [88, 364],
|
|
"name": "Quebec",
|
|
"flag": "Quebec"
|
|
},
|
|
{
|
|
"coordinates": [777, 170],
|
|
"name": "Nitassinan",
|
|
"flag": "Quebec"
|
|
},
|
|
{
|
|
"coordinates": [570, 460],
|
|
"name": "Anticosti Island",
|
|
"flag": "Quebec"
|
|
},
|
|
{
|
|
"coordinates": [300, 568],
|
|
"name": "Gaspesia",
|
|
"flag": "Quebec"
|
|
},
|
|
{
|
|
"coordinates": [256, 60],
|
|
"name": "Manicouagan",
|
|
"flag": "Quebec"
|
|
},
|
|
{
|
|
"coordinates": [522, 266],
|
|
"name": "Mingan",
|
|
"flag": "Quebec"
|
|
},
|
|
{
|
|
"coordinates": [1220, 632],
|
|
"name": "Newfoundland",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1166, 38],
|
|
"name": "Labrador",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1180, 199],
|
|
"name": "Northern Peninsula",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1544, 740],
|
|
"name": "St Johns",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1456, 620],
|
|
"name": "Bonavista",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1030, 528],
|
|
"name": "Corner Brook",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1254, 511],
|
|
"name": "Grand Falls",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [1040, 400],
|
|
"name": "Gros Morne",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [912, 720],
|
|
"name": "Port aux Basques",
|
|
"flag": "Newfoundland"
|
|
},
|
|
{
|
|
"coordinates": [82, 912],
|
|
"name": "New Brunswick",
|
|
"flag": "ca_nb"
|
|
},
|
|
{
|
|
"coordinates": [288, 742],
|
|
"name": "Acadia",
|
|
"flag": "ca_nb"
|
|
},
|
|
{
|
|
"coordinates": [184, 1000],
|
|
"name": "Fredericton",
|
|
"flag": "ca_nb"
|
|
},
|
|
{
|
|
"coordinates": [338, 938],
|
|
"name": "Moncton",
|
|
"flag": "ca_nb"
|
|
},
|
|
{
|
|
"coordinates": [44, 1110],
|
|
"name": "Maine",
|
|
"flag": "Maine"
|
|
},
|
|
{
|
|
"coordinates": [475, 915],
|
|
"name": "Prince Edward Island",
|
|
"flag": "ca_pe"
|
|
},
|
|
{
|
|
"coordinates": [588, 1054],
|
|
"name": "Nova Scotia",
|
|
"flag": "ca_ns"
|
|
},
|
|
{
|
|
"coordinates": [725, 920],
|
|
"name": "Cape Breton Island",
|
|
"flag": "ca_ns"
|
|
},
|
|
{
|
|
"coordinates": [310, 1130],
|
|
"name": "Annapolis",
|
|
"flag": "ca_ns"
|
|
},
|
|
{
|
|
"coordinates": [445, 1160],
|
|
"name": "Halifax",
|
|
"flag": "ca_ns"
|
|
},
|
|
{
|
|
"coordinates": [235, 1255],
|
|
"name": "Yarmouth",
|
|
"flag": "ca_ns"
|
|
}
|
|
],
|
|
"teamGameSpawnAreas": {
|
|
"3": [
|
|
{
|
|
"height": 500,
|
|
"width": 900,
|
|
"x": 0,
|
|
"y": 0
|
|
},
|
|
{
|
|
"height": 1348,
|
|
"width": 720,
|
|
"x": 900,
|
|
"y": 0
|
|
},
|
|
{
|
|
"height": 848,
|
|
"width": 900,
|
|
"x": 0,
|
|
"y": 500
|
|
}
|
|
]
|
|
}
|
|
}
|