mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-10 12:54:37 +00:00
a7f992e9b0
Restructure the single src/ tree into an npm-workspaces monorepo under
packages/, rename core -> engine, extract a types-only core-public layer,
and break the pre-existing engine -> client dependency cycle.
Structure (packages/):
core-public public API/wire schemas + shared enums (clean leaf)
shared framework-agnostic helpers (clean leaf)
engine deterministic simulation (was src/core)
client rendering/UI (was src/client)
server coordination (was src/server)
Dependency DAG: engine -> {core-public, shared}; client -> {core-public,
shared, engine}; server -> {core-public, engine}.
- npm workspaces: root package.json workspaces + per-package package.json;
tsconfig.base.json holds shared options + path aliases
(core-public/* shared/* engine/* client/* server/*) resolved uniformly by
tsc, Vite (resolve.tsconfigPaths), Vitest, and tsx. Lockfile regenerated.
- core-public: moved Schemas/ApiSchemas/CosmeticSchemas/StatsSchemas/
ClanApiSchemas/WorkerSchemas/Base64/PatternDecoder; extracted the enums
(GameTypes), GameEvent type, emoji table, and GraphicsOverrides schema.
Engine re-exports the moved enums/types so existing imports keep working.
- Broke engine -> client cycle:
- renderNumber/renderTroops -> shared/format
- NameBoxCalculator moved into engine
- username validation returns translation key + params; client translates
- applyStateUpdate moved to client (operates on the render-only PlayerState)
- Config/UnitGrid/execution-Util/GameImpl now use structural read
interfaces (engine/game/ReadViews: PlayerLike/UnitLike/GameLike) instead
of importing client view classes; client imports view classes from a new
client/view barrel; deleted the engine/game/GameView re-export shim.
- Build/deploy updated: vite.config, index.html, eslint, Dockerfile
(copies packages/ + tsconfig.base.json before npm ci), .vscode, tests.
Verified: tsc --noEmit clean; 1364 + 65 tests pass; production vite build
succeeds; engine has zero client/server imports; core-public and shared are
dependency leaves.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
68 lines
1.9 KiB
TypeScript
68 lines
1.9 KiB
TypeScript
import fs from "fs/promises";
|
|
import os from "os";
|
|
import path from "path";
|
|
import { afterEach, beforeEach, describe, expect, test, vi } from "vitest";
|
|
import {
|
|
clearAppShellContentCache,
|
|
getAppShellContent,
|
|
setAppShellCacheHeaders,
|
|
} from "server/RenderHtml";
|
|
|
|
describe("RenderHtml", () => {
|
|
const originalGitCommit = process.env.GIT_COMMIT;
|
|
let tempDir: string | null = null;
|
|
|
|
beforeEach(() => {
|
|
vi.stubEnv("NUM_WORKERS", "1");
|
|
vi.stubEnv("TURNSTILE_SITE_KEY", "test-key");
|
|
vi.stubEnv("DOMAIN", "localhost");
|
|
});
|
|
|
|
afterEach(async () => {
|
|
vi.unstubAllEnvs();
|
|
process.env.GIT_COMMIT = originalGitCommit;
|
|
clearAppShellContentCache();
|
|
|
|
if (tempDir) {
|
|
await fs.rm(tempDir, { recursive: true, force: true });
|
|
tempDir = null;
|
|
}
|
|
});
|
|
|
|
test("reuses cached app shell content", async () => {
|
|
tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "render-html-"));
|
|
const htmlPath = path.join(tempDir, "index.html");
|
|
await fs.writeFile(
|
|
htmlPath,
|
|
"<script>window.GIT_COMMIT = <%- gitCommit %>;</script>",
|
|
"utf8",
|
|
);
|
|
|
|
process.env.GIT_COMMIT = "first";
|
|
const first = await getAppShellContent(htmlPath);
|
|
|
|
process.env.GIT_COMMIT = "second";
|
|
const second = await getAppShellContent(htmlPath);
|
|
|
|
expect(first).toContain('"first"');
|
|
expect(second).toBe(first);
|
|
expect(second).not.toContain('"second"');
|
|
});
|
|
|
|
test("sets shared-cache headers for the app shell", () => {
|
|
const headers = new Map<string, string>();
|
|
const response = {
|
|
setHeader(name: string, value: string) {
|
|
headers.set(name, value);
|
|
},
|
|
} as any;
|
|
|
|
setAppShellCacheHeaders(response);
|
|
|
|
expect(headers.get("Cache-Control")).toBe(
|
|
"public, max-age=0, s-maxage=300, stale-while-revalidate=86400, stale-if-error=86400",
|
|
);
|
|
expect(headers.get("Content-Type")).toBe("text/html");
|
|
});
|
|
});
|