mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-10 13:34:36 +00:00
Evan Pelle
a7f992e9b0
Restructure the single src/ tree into an npm-workspaces monorepo under
packages/, rename core -> engine, extract a types-only core-public layer,
and break the pre-existing engine -> client dependency cycle.
Structure (packages/):
core-public public API/wire schemas + shared enums (clean leaf)
shared framework-agnostic helpers (clean leaf)
engine deterministic simulation (was src/core)
client rendering/UI (was src/client)
server coordination (was src/server)
Dependency DAG: engine -> {core-public, shared}; client -> {core-public,
shared, engine}; server -> {core-public, engine}.
- npm workspaces: root package.json workspaces + per-package package.json;
tsconfig.base.json holds shared options + path aliases
(core-public/* shared/* engine/* client/* server/*) resolved uniformly by
tsc, Vite (resolve.tsconfigPaths), Vitest, and tsx. Lockfile regenerated.
- core-public: moved Schemas/ApiSchemas/CosmeticSchemas/StatsSchemas/
ClanApiSchemas/WorkerSchemas/Base64/PatternDecoder; extracted the enums
(GameTypes), GameEvent type, emoji table, and GraphicsOverrides schema.
Engine re-exports the moved enums/types so existing imports keep working.
- Broke engine -> client cycle:
- renderNumber/renderTroops -> shared/format
- NameBoxCalculator moved into engine
- username validation returns translation key + params; client translates
- applyStateUpdate moved to client (operates on the render-only PlayerState)
- Config/UnitGrid/execution-Util/GameImpl now use structural read
interfaces (engine/game/ReadViews: PlayerLike/UnitLike/GameLike) instead
of importing client view classes; client imports view classes from a new
client/view barrel; deleted the engine/game/GameView re-export shim.
- Build/deploy updated: vite.config, index.html, eslint, Dockerfile
(copies packages/ + tsconfig.base.json before npm ci), .vscode, tests.
Verified: tsc --noEmit clean; 1364 + 65 tests pass; production vite build
succeeds; engine has zero client/server imports; core-public and shared are
dependency leaves.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
86 lines
2.9 KiB
TypeScript
86 lines
2.9 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { ClientMsgRateLimiter } from "server/ClientMsgRateLimiter";
|
|
|
|
const CLIENT_A = "clientA" as any;
|
|
const CLIENT_B = "clientB" as any;
|
|
|
|
const SMALL = 100;
|
|
|
|
describe("ClientMsgRateLimiter", () => {
|
|
describe("intent messages", () => {
|
|
it("allows intents within limits", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
expect(limiter.check(CLIENT_A, "intent", SMALL)).toBe("ok");
|
|
});
|
|
|
|
it("limits when per-second count exceeded", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
for (let i = 0; i < 10; i++) {
|
|
expect(limiter.check(CLIENT_A, "intent", SMALL)).toBe("ok");
|
|
}
|
|
expect(limiter.check(CLIENT_A, "intent", SMALL)).toBe("limit");
|
|
});
|
|
|
|
it("rate limits are per client", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
for (let i = 0; i < 10; i++) {
|
|
limiter.check(CLIENT_A, "intent", SMALL);
|
|
}
|
|
expect(limiter.check(CLIENT_B, "intent", SMALL)).toBe("ok");
|
|
});
|
|
|
|
it("allows intents up to MAX_INTENT_SIZE", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
expect(limiter.check(CLIENT_A, "intent", 2000)).toBe("ok");
|
|
});
|
|
|
|
it("kicks intents exceeding MAX_INTENT_SIZE", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
expect(limiter.check(CLIENT_A, "intent", 2001)).toBe("kick");
|
|
});
|
|
});
|
|
|
|
describe("non-intent messages", () => {
|
|
it("does not rate-limit non-intent messages", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
for (let i = 0; i < 20; i++) {
|
|
expect(limiter.check(CLIENT_A, "winner", 50)).toBe("ok");
|
|
}
|
|
});
|
|
|
|
it("does not rate-limit ping messages", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
for (let i = 0; i < 20; i++) {
|
|
expect(limiter.check(CLIENT_A, "ping", 50)).toBe("ok");
|
|
}
|
|
});
|
|
});
|
|
|
|
describe("total bytes limit", () => {
|
|
it("kicks when cumulative bytes reach 2MB", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
const chunkSize = 512 * 1024; // 512KB
|
|
// Send 3 chunks = 1.5MB, should be ok
|
|
for (let i = 0; i < 3; i++) {
|
|
expect(limiter.check(CLIENT_A, "other", chunkSize)).toBe("ok");
|
|
}
|
|
// 4th chunk pushes to 2MB, should kick
|
|
expect(limiter.check(CLIENT_A, "other", chunkSize)).toBe("kick");
|
|
});
|
|
|
|
it("byte tracking is per client", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
const almostFull = 2 * 1024 * 1024 - 1;
|
|
expect(limiter.check(CLIENT_A, "other", almostFull)).toBe("ok");
|
|
// CLIENT_B should still be fine
|
|
expect(limiter.check(CLIENT_B, "other", 100)).toBe("ok");
|
|
});
|
|
|
|
it("kicks on bytes regardless of message type", () => {
|
|
const limiter = new ClientMsgRateLimiter();
|
|
const twoMB = 2 * 1024 * 1024;
|
|
expect(limiter.check(CLIENT_A, "intent", twoMB)).toBe("kick");
|
|
});
|
|
});
|
|
});
|