mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-10 12:24:36 +00:00
a7f992e9b0
Restructure the single src/ tree into an npm-workspaces monorepo under
packages/, rename core -> engine, extract a types-only core-public layer,
and break the pre-existing engine -> client dependency cycle.
Structure (packages/):
core-public public API/wire schemas + shared enums (clean leaf)
shared framework-agnostic helpers (clean leaf)
engine deterministic simulation (was src/core)
client rendering/UI (was src/client)
server coordination (was src/server)
Dependency DAG: engine -> {core-public, shared}; client -> {core-public,
shared, engine}; server -> {core-public, engine}.
- npm workspaces: root package.json workspaces + per-package package.json;
tsconfig.base.json holds shared options + path aliases
(core-public/* shared/* engine/* client/* server/*) resolved uniformly by
tsc, Vite (resolve.tsconfigPaths), Vitest, and tsx. Lockfile regenerated.
- core-public: moved Schemas/ApiSchemas/CosmeticSchemas/StatsSchemas/
ClanApiSchemas/WorkerSchemas/Base64/PatternDecoder; extracted the enums
(GameTypes), GameEvent type, emoji table, and GraphicsOverrides schema.
Engine re-exports the moved enums/types so existing imports keep working.
- Broke engine -> client cycle:
- renderNumber/renderTroops -> shared/format
- NameBoxCalculator moved into engine
- username validation returns translation key + params; client translates
- applyStateUpdate moved to client (operates on the render-only PlayerState)
- Config/UnitGrid/execution-Util/GameImpl now use structural read
interfaces (engine/game/ReadViews: PlayerLike/UnitLike/GameLike) instead
of importing client view classes; client imports view classes from a new
client/view barrel; deleted the engine/game/GameView re-export shim.
- Build/deploy updated: vite.config, index.html, eslint, Dockerfile
(copies packages/ + tsconfig.base.json before npm ci), .vscode, tests.
Verified: tsc --noEmit clean; 1364 + 65 tests pass; production vite build
succeeds; engine has zero client/server imports; core-public and shared are
dependency leaves.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
65 lines
2.0 KiB
TypeScript
65 lines
2.0 KiB
TypeScript
import { installSafariPinchZoomBlocker } from "client/utilities/DisableSafariPinchZoom";
|
|
|
|
const GESTURE_EVENTS = ["gesturestart", "gesturechange", "gestureend"] as const;
|
|
|
|
function dispatchCancelableGestureEvent(
|
|
target: EventTarget,
|
|
type: string,
|
|
): Event {
|
|
// Safari's GestureEvent is not available in jsdom. Dispatch a plain
|
|
// cancelable Event of the same name so preventDefault() is observable via
|
|
// defaultPrevented.
|
|
const event = new Event(type, { bubbles: true, cancelable: true });
|
|
target.dispatchEvent(event);
|
|
return event;
|
|
}
|
|
|
|
describe("installSafariPinchZoomBlocker", () => {
|
|
it("calls preventDefault on each Safari gesture event dispatched at the target", () => {
|
|
const target = document.createElement("div");
|
|
installSafariPinchZoomBlocker(target);
|
|
|
|
for (const type of GESTURE_EVENTS) {
|
|
const event = dispatchCancelableGestureEvent(target, type);
|
|
expect(event.defaultPrevented).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("defaults to attaching the listeners to document", () => {
|
|
const addEventListenerSpy = vi
|
|
.spyOn(document, "addEventListener")
|
|
.mockImplementation(() => {});
|
|
|
|
try {
|
|
installSafariPinchZoomBlocker();
|
|
|
|
for (const type of GESTURE_EVENTS) {
|
|
expect(addEventListenerSpy).toHaveBeenCalledWith(
|
|
type,
|
|
expect.any(Function),
|
|
);
|
|
}
|
|
} finally {
|
|
addEventListenerSpy.mockRestore();
|
|
}
|
|
});
|
|
|
|
it("does not affect events dispatched at unrelated targets", () => {
|
|
const scope = document.createElement("div");
|
|
const other = document.createElement("div");
|
|
installSafariPinchZoomBlocker(scope);
|
|
|
|
const event = dispatchCancelableGestureEvent(other, "gesturestart");
|
|
expect(event.defaultPrevented).toBe(false);
|
|
});
|
|
|
|
it("leaves unrelated event types alone", () => {
|
|
const target = document.createElement("div");
|
|
installSafariPinchZoomBlocker(target);
|
|
|
|
const event = new Event("touchstart", { bubbles: true, cancelable: true });
|
|
target.dispatchEvent(event);
|
|
expect(event.defaultPrevented).toBe(false);
|
|
});
|
|
});
|