Files
OpenFrontIO/tests/util/viewStubs.ts
T
Evan 1db02acdc2 Move theme data into the render-settings JSON pipeline (#4223)
**Add approved & assigned issue number here:**

N/A — maintainer refactor.

## Description:

Replaces the theme class hierarchy
(`BaseTheme`/`PastelTheme`/`ColorblindTheme`) with theme JSON files —
`default-theme.json` and `colorblind-theme.json` — combined with
`render-settings.json` at runtime into a single graphics-configuration
pipeline (`settings.theme`). One `SettingsTheme` class keeps the
algorithms (color allocation, team-variation generation, LAB-contrast
structure colors) and reads all data from `ThemeSettings`; adding a
theme is now just adding a JSON file.

Colorblind mode (#4150) is fully preserved:

- Same palettes — the 32-color CVD-safe pool and Okabe-Ito team colors
are baked into `colorblind-theme.json`
- The relative border rule (`l × 0.6`) is expressed as a
`borderLightnessScale` knob alongside the default theme's absolute
`borderDarken`
- The mid-game re-theme wiring (`refreshPlayerColors`/`refreshPalette`)
and the affiliation/friend-foe tint overrides are unchanged;
`applyGraphicsOverrides` now also swaps the `settings.theme` slice
- `deepAssign` replaces arrays wholesale so differing palette lengths
survive theme switches

Verified against the previous implementation with an equivalence test
(since removed): default-theme colors are byte-identical including
allocation order; colorblind team/derived colors are byte-identical, and
FFA assignment may permute within the same palette (hex baking rounds
upstream's fractional-RGB colord objects, which can flip the allocator's
greedy delta-E ordering — rendered colors round identically either way).

Also removes dead theme surface (`terrainColor`, `backgroundColor`,
`falloutColor`, `font`, `textColor`, spawn-highlight variants,
`PastelThemeDark`) — GL terrain colors and dark mode were already
handled in the renderer. Note this means the colorblind terrain bands
from #4150 were dead code (nothing calls `terrainColor`; GL terrain
comes from `ColorUtils.encodeTerrainTile`); wiring CVD-safe terrain into
the terrain texture would be a follow-up.

## Please complete the following:

- [x] I have added screenshots for all UI updates — N/A, no UI changes
(verified color-identical)
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file — N/A, no user-visible text
- [x] I have added relevant tests to the test directory —
`tests/Colors.test.ts` updated for the new pipeline (team colors from
theme JSON, colorblind palette/border tests)

## Please put your Discord username so you can be contacted if a bug or
regression is found:

evanpelle

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-06-11 12:50:50 -07:00

213 lines
5.7 KiB
TypeScript

/**
* Stub builders for GameView/PlayerView/UnitView unit tests.
*
* These tests don't go through the full game setup (which creates a worker
* and runs the simulation) — they exercise the view classes directly with
* minimal stubs for their dependencies.
*/
import { colord } from "colord";
import { Theme } from "../../src/client/theme/ThemeProvider";
import { GameView } from "../../src/client/view/GameView";
import { PlayerView } from "../../src/client/view/PlayerView";
import { Config } from "../../src/core/configuration/Config";
import {
NameViewData,
PlayerType,
Team,
UnitType,
} from "../../src/core/game/Game";
import { GameMapImpl } from "../../src/core/game/GameMap";
import {
GameUpdateType,
GameUpdateViewData,
PlayerUpdate,
UnitUpdate,
} from "../../src/core/game/GameUpdates";
import { TerrainMapData } from "../../src/core/game/TerrainMapLoader";
import { Player, PlayerCosmetics } from "../../src/core/Schemas";
import { WorkerClient } from "../../src/core/worker/WorkerClient";
/** Theme stub — returns deterministic colors so PlayerView's color math works. */
export function stubTheme(): Theme {
const white = colord("#ffffff");
const grey = colord("#808080");
const defended = { light: white, dark: grey };
return {
teamColor: () => white,
territoryColor: () => white,
structureColors: () => defended,
borderColor: () => grey,
defendedBorderColors: () => defended,
focusedBorderColor: () => grey,
spawnHighlightColor: () => white,
};
}
/** Minimum Config stub for view tests. Extend as test needs grow. */
export function stubConfig(overrides: Partial<Config> = {}): Config {
const theme = stubTheme();
const cfg = {
theme: () => theme,
SAMCooldown: () => 120,
SiloCooldown: () => 75,
deleteUnitCooldown: () => 0,
spawnImmunityDuration: () => 0,
nationSpawnImmunityDuration: () => 0,
unitInfo: () => ({ maxHealth: 100, constructionDuration: 20 }),
disableAlliances: () => false,
allianceDuration: () => 100,
deletionMarkDuration: () => 300,
nukeMagnitudes: () => ({ inner: 0, outer: 0 }),
nukeAllianceBreakThreshold: () => 0,
userSettings: () => ({}),
...overrides,
} as unknown as Config;
return cfg;
}
/** WorkerClient stub. View classes only call worker.* in async methods we don't exercise. */
export function stubWorker(): WorkerClient {
return {} as unknown as WorkerClient;
}
/** Build TerrainMapData wrapping a fresh GameMapImpl of the given size. */
export function stubTerrainMap(width = 10, height = 10): TerrainMapData {
const terrain = new Uint8Array(width * height);
const gameMap = new GameMapImpl(width, height, terrain, 0);
return {
nations: [],
additionalNations: [],
gameMap,
miniGameMap: gameMap,
} as unknown as TerrainMapData;
}
export interface GameViewStubOptions {
width?: number;
height?: number;
myClientID?: string;
myUsername?: string;
myClanTag?: string | null;
humans?: Player[];
config?: Config;
}
/** Construct a GameView with minimal dependencies. */
export function makeGameView(opts: GameViewStubOptions = {}): GameView {
return new GameView(
stubWorker(),
opts.config ?? stubConfig(),
stubTerrainMap(opts.width ?? 10, opts.height ?? 10),
opts.myClientID,
opts.myUsername ?? "tester",
opts.myClanTag ?? null,
"test-game",
opts.humans ?? [],
);
}
// ── Synthetic update builders ──
export function makePlayerUpdate(
overrides: Partial<PlayerUpdate> = {},
): PlayerUpdate {
return {
type: GameUpdateType.Player,
clientID: "client-a",
name: "Alice",
displayName: "Alice",
id: "player-a",
smallID: 1,
playerType: PlayerType.Human,
isAlive: true,
isDisconnected: false,
tilesOwned: 0,
gold: 0n,
troops: 100,
allies: [],
embargoes: new Set(),
isTraitor: false,
targets: [],
outgoingEmojis: [],
outgoingAttacks: [],
incomingAttacks: [],
outgoingAllianceRequests: [],
alliances: [],
hasSpawned: true,
betrayals: 0,
lastDeleteUnitTick: 0,
isLobbyCreator: false,
...overrides,
};
}
export function makeUnitUpdate(
overrides: Partial<UnitUpdate> = {},
): UnitUpdate {
return {
type: GameUpdateType.Unit,
unitType: UnitType.Warship,
troops: 0,
id: 1,
ownerID: 1,
pos: 0,
lastPos: 0,
isActive: true,
reachedTarget: false,
targetable: true,
markedForDeletion: false,
missileTimerQueue: [],
level: 1,
hasTrainStation: false,
...overrides,
};
}
export function makeNameViewData(
overrides: Partial<NameViewData> = {},
): NameViewData {
return { x: 0, y: 0, size: 12, ...overrides };
}
export interface PlayerViewStubOptions {
game?: GameView;
data?: Partial<PlayerUpdate>;
nameData?: NameViewData;
cosmetics?: PlayerCosmetics;
}
/** Construct a PlayerView with minimal dependencies. */
export function makePlayerView(opts: PlayerViewStubOptions = {}): PlayerView {
return new PlayerView(
opts.game ?? makeGameView(),
makePlayerUpdate(opts.data),
opts.nameData ?? makeNameViewData(),
opts.cosmetics ?? {},
);
}
/**
* Build a GameUpdateViewData with no updates and an empty packed tile delta.
* Caller can fill in updates[GameUpdateType.X] arrays as needed.
*/
export function makeEmptyGu(
tick: number,
overrides: Partial<GameUpdateViewData> = {},
): GameUpdateViewData {
const updates = Object.fromEntries(
Object.values(GameUpdateType)
.filter((v): v is number => typeof v === "number")
.map((k) => [k, []]),
) as unknown as GameUpdateViewData["updates"];
return {
tick,
updates,
packedTileUpdates: new Uint32Array(0),
playerNameViewData: {},
...overrides,
};
}
export { Team };