mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 10:32:41 +00:00
Evan
182d008ddd
**Add approved & assigned issue number here:** N/A — maintainer follow-up to #4227. ## Description: Follow-up to #4227, finishing the "info.json is the single source of truth" refactor. **Maps.gen.ts now generates one `MapInfo` interface and a `maps` list** instead of parallel lookup records. `mapCategories`, `mapTranslationKeys`, and `multiplayerFrequency` are gone — consumers read the list directly (`map.categories`, `map.translationKey`, `map.multiplayerFrequency`). MapPicker got simpler in the process: it renders from `MapInfo` objects, so the reverse `Object.entries(GameMapType)` lookup to recover the enum key is gone. The featured-rank sort moved out of the Go codegen into the picker, where the presentation concern belongs. **`SPECIAL_TEAM_MAPS` moves into info.json** as an optional `special_team_count` field (set on the same 17 maps with the same values). MapPlaylist derives its map from the generated list; `SPECIAL_TEAM_FORCE_CHANCE` and the frequency multiplier behavior are unchanged. **The en.json `map` section is now generated.** A new optional `display_name` field in info.json (defaulting to `name`) is written to `resources/lang/en.json` by the generator, preserving the section's non-map UI keys (`map`, `featured`, `all`, `favorites`, `random`). The 8 maps whose English display name intentionally differs from the frozen enum value (e.g. `MENA`, `Milky Way`, `Europe (Classic)`, `Baikal (Nuke Wars)`) declare it via `display_name`, so no display text changes. The section is emitted alphabetically; since #4232 already sorted en.json and every value matches, regeneration is byte-identical and this PR has no en.json diff. Other languages remain Crowdin-managed. The generator also now validates `translation_key` is exactly `map.<folder>` and `special_team_count >= 2`. MapConsistency tests compare info.json directly against the generated list and the en.json section, and fail with a "run `npm run gen-maps`" message on drift. No behavior changes: enum values, playlist frequencies, special-team counts, featured order, and display names are all byte-identical. ## Please complete the following: - [x] I have added screenshots for all UI updates (no UI changes — internal refactor, rendering output identical) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: evanpelle 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
126 lines
2.5 KiB
JSON
126 lines
2.5 KiB
JSON
{
|
|
"id": "BritanniaClassic",
|
|
"name": "Britannia Classic",
|
|
"display_name": "Britannia (Classic)",
|
|
"translation_key": "map.britanniaclassic",
|
|
"categories": ["europe"],
|
|
"multiplayer_frequency": 0,
|
|
"nations": [
|
|
{
|
|
"coordinates": [960, 1258],
|
|
"name": "Dumnonia",
|
|
"flag": "1_Dumnonia"
|
|
},
|
|
{
|
|
"coordinates": [918, 1088],
|
|
"name": "Dyfed",
|
|
"flag": "1_Dyfed"
|
|
},
|
|
{
|
|
"coordinates": [1114, 1108],
|
|
"name": "Gwent",
|
|
"flag": "1_Gwent"
|
|
},
|
|
{
|
|
"coordinates": [1048, 936],
|
|
"name": "Gwynedd",
|
|
"flag": "1_Gwynedd"
|
|
},
|
|
{
|
|
"coordinates": [1108, 986],
|
|
"name": "Powys",
|
|
"flag": "1_Powys"
|
|
},
|
|
{
|
|
"coordinates": [952, 536],
|
|
"name": "Strathclyde",
|
|
"flag": "1_Strathclyde"
|
|
},
|
|
{
|
|
"coordinates": [748, 556],
|
|
"name": "Dalriata",
|
|
"flag": "1_Dalriata"
|
|
},
|
|
{
|
|
"coordinates": [1228, 1176],
|
|
"name": "Wessex",
|
|
"flag": "1_Wessex"
|
|
},
|
|
{
|
|
"coordinates": [1442, 1226],
|
|
"name": "Sussex",
|
|
"flag": "1_Sussex"
|
|
},
|
|
{
|
|
"coordinates": [1600, 1188],
|
|
"name": "Kent",
|
|
"flag": "1_Kent"
|
|
},
|
|
{
|
|
"coordinates": [1621, 1085],
|
|
"name": "Essex",
|
|
"flag": "1_Essex"
|
|
},
|
|
{
|
|
"coordinates": [1707, 1018],
|
|
"name": "East Anglia",
|
|
"flag": "1_East Anglia"
|
|
},
|
|
{
|
|
"coordinates": [1370, 1002],
|
|
"name": "Mercia",
|
|
"flag": "1_Mercia"
|
|
},
|
|
{
|
|
"coordinates": [1298, 724],
|
|
"name": "Northumbria",
|
|
"flag": "1_Northumbria"
|
|
},
|
|
{
|
|
"coordinates": [962, 366],
|
|
"name": "Fortriu",
|
|
"flag": "1_Fortriu"
|
|
},
|
|
{
|
|
"coordinates": [272, 1041],
|
|
"name": "Munster",
|
|
"flag": "1_Munster"
|
|
},
|
|
{
|
|
"coordinates": [264, 830],
|
|
"name": "Connacht",
|
|
"flag": "1_Connacht"
|
|
},
|
|
{
|
|
"coordinates": [608, 975],
|
|
"name": "Laigin",
|
|
"flag": "1_Laigin"
|
|
},
|
|
{
|
|
"coordinates": [564, 845],
|
|
"name": "Southern Uí Néill",
|
|
"flag": "1_Southern Ui Neill"
|
|
},
|
|
{
|
|
"coordinates": [639, 680],
|
|
"name": "Ulaid",
|
|
"flag": "1_Ulaid"
|
|
},
|
|
{
|
|
"coordinates": [509, 759],
|
|
"name": "Airgialla",
|
|
"flag": "1_Airgialla"
|
|
},
|
|
{
|
|
"coordinates": [416, 678],
|
|
"name": "Northern Uí Néill",
|
|
"flag": "1_Northern Ui Neill"
|
|
},
|
|
{
|
|
"coordinates": [1869, 1308],
|
|
"name": "Franks",
|
|
"flag": "1_Franks"
|
|
}
|
|
]
|
|
}
|