mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 19:16:44 +00:00
b090f2f624
## Pathfinding with HPA*
Hi! The primary objective of this PR is to replace per-tile A* with
hierarchical pathfinding - HPA*. In practice, this means we create an
abstract graph on top of the actual map with far fewer points and use it
to decide on general path structure. Only then we go back to tile-level
and build path between selected waypoints. This speeds up long distance
pathfinding by over 1000x in some cases. To make the review easier, it
comes with a benchmark and visual playground.
## PREPROCESSING
H part of HPA* means "hierarchical" and requires preprocessing.
This PR includes pre-processing as part inside `new Game()` constructor.
It takes about 135ms for `giantworldmap` on my machine, which increases
the effective initialization from ~95ms to ~230ms. This time could be
reduced in different ways, which are **out of scope** for this PR.
After confirming the initialization time is bearable on low-end devices,
I argue merging this PR as-is is acceptable tradeoff. It creates small
lag at the beginning of a round but pays for itself in the first minute
of the match.
## Nerdy details
**Architecture**
- HPA*-style hierarchical pathfinding
- 32×32 sectors on minimap with gateway nodes on borders
- Gateway graph built via BFS during preprocessing
- Water component optimization skips unreachable gateway pairs
- A* on gateway graph → local A* within sectors → Bresenham path
smoothing
- Minimap upscaling identical to currently used in MiniAStar
**Key Optimizations**
- Typed arrays instead of high-level primitives
- Stamp-based visited tracking (no need to recreate buffers, O(1)
clearing)
- Optional - enabled by default - caching of tile paths between gateways
- Line of sight smoothing for the final path
## Review Focus
Play with included tools, benchmark and visualization. Pathfinding
should be safe to merge as a black box - you do not need to understand
the details. Outcomes can be tested empirically in-game. Visualize (and
share!) edge cases with included playground. Confirm the 100x speedup is
real with benchmark.
If you plan to dive into the code, I suggest the following order:
- Pathfinding abstraction in `src/core/pathfinding/`
- Pathfinding tests in `tests/core/pathfinding/`
- NavMesh in `src/core/pathfinding/navmesh/` + integration with
`Game.ts`
- Benchmark in `tests/pathfinding/benchmark/`
Do not look at playground's code, it has been created with a clanker.
The design is 100% mine and I spent way too long polishing it, but I
haven't even once edited the code manually. There is probably no
abstraction whatsoever, just do not look at the code, let it play.
## Core Changes
#### Pathfinding (`src/core/pathfinding/navmesh/`)
- HPA* + refinement -> three phased pathfinding: A* over the graph ->
naive path -> refinement
- comes with A* and BFS optimized for for specific needs
#### Pre-Processing (`src/core/pathfinding/navmesh/`)
- identify water bodies to avoid pathfinding between disconnected nodes
- create high-level graph of gateways on top of tile map
#### Abstraction (`src/core/pathfinding/`)
- common `PathFinder` interface that can return full path and also act
as state machine (`.next()`)
- adapters for both new and legacy algorithm with fallback to legacy if
navigation mesh not available
#### Benchmark (`tests/pathfinding/benchmark/`)
- `npx tsx tests/pathfinding/benchmark/run.ts` - no guesswork, numbers
- `npx tsx tests/pathfinding/benchmark/run.ts --synthetic` - 1000s of
synthetic paths
- `npx tsc tests/pathfinding/benchmark/generate.ts` - generate more as
needed, test new maps
- includes ONE synthetic scenario to avoid PR bloat, generate more
locally / later
#### Playground (`tests/pathfinding/playground/`)
- `npx tsx tests/pathfinding/playground/server.ts` - visualize paths
with both new and legacy algorithm
## Benchmarks
### Compared with legacy in default - hand picked - scenario:
```
Initialization: 95.95ms -> 227.29ms
Pathfinding: 3038.43ms -> 6.45ms
Distance: 26972 -> 26810 tiles
```
### 42,000 synthetic routes across all maps
```
Running 42 synthetic scenarios with hpa.cached adapter...
✅ synthetic/achiran | Init: 93.42ms | Path: 139.07ms | Dist: 1481630 tiles | Routes: 1000/1000
✅ synthetic/africa | Init: 87.14ms | Path: 155.08ms | Dist: 1829414 tiles | Routes: 1000/1000
✅ synthetic/asia | Init: 57.60ms | Path: 112.55ms | Dist: 1204082 tiles | Routes: 1000/1000
✅ synthetic/australia | Init: 78.18ms | Path: 77.12ms | Dist: 978375 tiles | Routes: 1000/1000
✅ synthetic/baikal | Init: 78.26ms | Path: 152.14ms | Dist: 1600016 tiles | Routes: 1000/1000
✅ synthetic/baikalnukewars | Init: 81.44ms | Path: 165.90ms | Dist: 1699283 tiles | Routes: 1000/1000
✅ synthetic/betweentwoseas | Init: 29.29ms | Path: 114.99ms | Dist: 1338075 tiles | Routes: 1000/1000
✅ synthetic/blacksea | Init: 30.66ms | Path: 93.14ms | Dist: 949217 tiles | Routes: 1000/1000
✅ synthetic/britannia | Init: 74.12ms | Path: 85.62ms | Dist: 866752 tiles | Routes: 1000/1000
✅ synthetic/deglaciatedantarctica | Init: 105.49ms | Path: 192.93ms | Dist: 1574684 tiles | Routes: 1000/1000
✅ synthetic/didier | Init: 81.51ms | Path: 153.70ms | Dist: 1734876 tiles | Routes: 1000/1000
✅ synthetic/eastasia | Init: 49.29ms | Path: 128.63ms | Dist: 1410270 tiles | Routes: 1000/1000
✅ synthetic/europe | Init: 92.55ms | Path: 178.35ms | Dist: 1525216 tiles | Routes: 1000/1000
✅ synthetic/europeclassic | Init: 33.50ms | Path: 104.40ms | Dist: 1209759 tiles | Routes: 1000/1000
✅ synthetic/falklandislands | Init: 63.00ms | Path: 107.41ms | Dist: 1080251 tiles | Routes: 1000/1000
✅ synthetic/faroeislands | Init: 71.91ms | Path: 49.52ms | Dist: 604613 tiles | Routes: 1000/1000
✅ synthetic/fourislands | Init: 45.75ms | Path: 78.91ms | Dist: 937439 tiles | Routes: 1000/1000
✅ synthetic/gatewaytotheatlantic | Init: 81.00ms | Path: 257.06ms | Dist: 2555551 tiles | Routes: 1000/1000
✅ synthetic/giantworldmap | Init: 214.25ms | Path: 220.42ms | Dist: 1976693 tiles | Routes: 1000/1000
✅ synthetic/gulfofstlawrence | Init: 45.16ms | Path: 96.05ms | Dist: 1014604 tiles | Routes: 1000/1000
✅ synthetic/halkidiki | Init: 74.68ms | Path: 149.39ms | Dist: 1546781 tiles | Routes: 1000/1000
✅ synthetic/iceland | Init: 58.72ms | Path: 78.16ms | Dist: 1001554 tiles | Routes: 1000/1000
✅ synthetic/italia | Init: 29.78ms | Path: 139.93ms | Dist: 1412024 tiles | Routes: 1000/1000
✅ synthetic/japan | Init: 161.07ms | Path: 118.65ms | Dist: 1154393 tiles | Routes: 1000/1000
✅ synthetic/lemnos | Init: 52.59ms | Path: 136.69ms | Dist: 1481101 tiles | Routes: 1000/1000
✅ synthetic/lisbon | Init: 49.27ms | Path: 86.53ms | Dist: 1032011 tiles | Routes: 1000/1000
✅ synthetic/manicouagan | Init: 53.74ms | Path: 110.52ms | Dist: 1307630 tiles | Routes: 1000/1000
✅ synthetic/mars | Init: 29.39ms | Path: 80.55ms | Dist: 1091702 tiles | Routes: 1000/1000
✅ synthetic/mena | Init: 26.37ms | Path: 120.09ms | Dist: 1272751 tiles | Routes: 1000/1000
✅ synthetic/montreal | Init: 26.08ms | Path: 106.77ms | Dist: 1187736 tiles | Routes: 1000/1000
✅ synthetic/newyorkcity | Init: 56.60ms | Path: 181.19ms | Dist: 1753875 tiles | Routes: 1000/1000
✅ synthetic/northamerica | Init: 96.29ms | Path: 123.02ms | Dist: 1217221 tiles | Routes: 1000/1000
✅ synthetic/oceania | Init: 52.81ms | Path: 51.96ms | Dist: 482373 tiles | Routes: 1000/1000
✅ synthetic/pangaea | Init: 21.29ms | Path: 56.58ms | Dist: 716189 tiles | Routes: 1000/1000
✅ synthetic/pluto | Init: 53.89ms | Path: 141.62ms | Dist: 1304362 tiles | Routes: 1000/1000
✅ synthetic/southamerica | Init: 85.19ms | Path: 123.03ms | Dist: 1301403 tiles | Routes: 1000/1000
✅ synthetic/straitofgibraltar | Init: 76.68ms | Path: 108.30ms | Dist: 1304592 tiles | Routes: 1000/1000
✅ synthetic/straitofhormuz | Init: 38.97ms | Path: 67.78ms | Dist: 754920 tiles | Routes: 1000/1000
✅ synthetic/surrounded | Init: 95.35ms | Path: 90.18ms | Dist: 1017142 tiles | Routes: 1000/1000
✅ synthetic/svalmel | Init: 60.58ms | Path: 104.75ms | Dist: 1235501 tiles | Routes: 1000/1000
✅ synthetic/twolakes | Init: 62.05ms | Path: 94.54ms | Dist: 1140807 tiles | Routes: 1000/1000
✅ synthetic/world | Init: 41.43ms | Path: 93.42ms | Dist: 873406 tiles | Routes: 1000/1000
Completed 42 scenarios
Total Initialization Time: 2796.32ms
Total Pathfinding Time: 5026.64ms
Total Distance: 53160274 tiles
```
## Playground
**That's the fun part**. Watch NavMesh running circles around legacy
`PathFinder.Mini` in real time. Debug inner workings, test edge cases,
share URLs for debugging.
https://github.com/user-attachments/assets/34e2e3f5-fbc1-4b1f-917d-820766e98d5d
## Discord Tag
`moleole`
288 lines
8.6 KiB
JavaScript
288 lines
8.6 KiB
JavaScript
#!/usr/bin/env node
|
|
|
|
/**
|
|
* Benchmark pathfinding adapters on various scenarios
|
|
*
|
|
* Usage:
|
|
* npx tsx tests/pathfinding/benchmark/run.ts [<scenario> [<adapter>]]
|
|
* npx tsx tests/pathfinding/benchmark/run.ts --synthetic <map-name> [<adapter>]
|
|
* npx tsx tests/pathfinding/benchmark/run.ts --synthetic --all [<adapter>]
|
|
*
|
|
* Examples:
|
|
* npx tsx tests/pathfinding/benchmark/run.ts
|
|
* npx tsx tests/pathfinding/benchmark/run.ts default legacy
|
|
* npx tsx tests/pathfinding/benchmark/run.ts --synthetic --all
|
|
* npx tsx tests/pathfinding/benchmark/run.ts --synthetic iceland legacy
|
|
*/
|
|
|
|
import { readdirSync } from "fs";
|
|
import { dirname, join } from "path";
|
|
import { fileURLToPath } from "url";
|
|
import {
|
|
type BenchmarkResult,
|
|
calculateStats,
|
|
getAdapter,
|
|
getScenario,
|
|
measureExecutionTime,
|
|
measurePathLength,
|
|
printHeader,
|
|
printRow,
|
|
} from "../utils";
|
|
|
|
const currentFile = fileURLToPath(import.meta.url);
|
|
const pathfindingDir = dirname(currentFile);
|
|
const syntheticScenariosDir = join(pathfindingDir, "scenarios", "synthetic");
|
|
|
|
interface RunOptions {
|
|
silent?: boolean;
|
|
iterations?: number;
|
|
}
|
|
|
|
const DEFAULT_ADAPTER = "hpa";
|
|
const DEFAULT_SCENARIO = "default";
|
|
const DEFAULT_ITERATIONS = 10;
|
|
|
|
async function runScenario(
|
|
adapterName: string,
|
|
scenarioName: string,
|
|
options: RunOptions = {},
|
|
) {
|
|
const { game, routes, initTime } = await getScenario(
|
|
scenarioName,
|
|
adapterName,
|
|
);
|
|
const adapter = getAdapter(game, adapterName);
|
|
const { silent = false } = options;
|
|
|
|
if (!silent) {
|
|
console.log(`Date: ${new Date().toISOString()}`);
|
|
console.log(`Benchmarking: ${adapterName}`);
|
|
console.log(`Scenario: ${scenarioName}`);
|
|
console.log(`Routes: ${routes.length}`);
|
|
console.log(``);
|
|
}
|
|
|
|
// =============================================================================
|
|
|
|
if (!silent) {
|
|
printHeader("METRIC 1: INITIALIZATION TIME");
|
|
}
|
|
|
|
const initializationTime = initTime;
|
|
|
|
if (!silent) {
|
|
console.log(`Initialization time: ${initializationTime.toFixed(2)}ms`);
|
|
console.log(``);
|
|
}
|
|
|
|
// =============================================================================
|
|
|
|
if (!silent) {
|
|
printHeader("METRIC 2: PATH DISTANCE");
|
|
printRow(["Route", "Path Length"], [40, 12]);
|
|
}
|
|
|
|
const results: BenchmarkResult[] = [];
|
|
|
|
for (const route of routes) {
|
|
const pathLength = measurePathLength(adapter, route);
|
|
results.push({ route: route.name, pathLength, executionTime: null });
|
|
if (!silent) {
|
|
printRow(
|
|
[route.name, pathLength !== null ? `${pathLength} tiles` : "FAILED"],
|
|
[40, 12],
|
|
);
|
|
}
|
|
}
|
|
|
|
const { totalDistance, successfulRoutes, totalRoutes } =
|
|
calculateStats(results);
|
|
|
|
if (!silent) {
|
|
console.log(``);
|
|
console.log(`Total distance: ${totalDistance} tiles`);
|
|
console.log(`Routes completed: ${successfulRoutes} / ${totalRoutes}`);
|
|
console.log(``);
|
|
}
|
|
|
|
// =============================================================================
|
|
|
|
if (!silent) {
|
|
printHeader("METRIC 3: PATHFINDING TIME");
|
|
printRow(["Route", "Time"], [40, 12]);
|
|
}
|
|
|
|
for (const route of routes) {
|
|
const result = results.find((r) => r.route === route.name);
|
|
|
|
if (result && result.pathLength !== null) {
|
|
const execTime = measureExecutionTime(
|
|
adapter,
|
|
route,
|
|
options.iterations ?? DEFAULT_ITERATIONS,
|
|
);
|
|
result.executionTime = execTime;
|
|
|
|
if (!silent) {
|
|
printRow([route.name, `${execTime!.toFixed(2)}ms`], [40, 12]);
|
|
}
|
|
} else {
|
|
if (!silent) {
|
|
printRow([route.name, "FAILED"], [40, 12]);
|
|
}
|
|
}
|
|
}
|
|
|
|
const stats = calculateStats(results);
|
|
|
|
if (!silent) {
|
|
console.log(``);
|
|
console.log(`Total time: ${stats.totalTime.toFixed(2)}ms`);
|
|
console.log(`Average time: ${stats.avgTime.toFixed(2)}ms`);
|
|
console.log(
|
|
`Routes benchmarked: ${stats.timedRoutes} / ${stats.totalRoutes}`,
|
|
);
|
|
console.log(``);
|
|
|
|
// =============================================================================
|
|
|
|
printHeader("SUMMARY");
|
|
|
|
console.log(`Adapter: ${adapterName}`);
|
|
console.log(`Scenario: ${scenarioName}`);
|
|
console.log(``);
|
|
|
|
if (stats.successfulRoutes < stats.totalRoutes) {
|
|
console.log(
|
|
`Warning: Only ${stats.successfulRoutes} out of ${stats.totalRoutes} routes were completed successfully!`,
|
|
);
|
|
console.log(``);
|
|
}
|
|
|
|
console.log("Scores:");
|
|
console.log(` Initialization: ${initializationTime.toFixed(2)}ms`);
|
|
console.log(` Pathfinding: ${stats.totalTime.toFixed(2)}ms`);
|
|
console.log(` Distance: ${totalDistance} tiles`);
|
|
console.log(``);
|
|
} else {
|
|
// Silent mode - just print a summary line
|
|
const status = stats.successfulRoutes < stats.totalRoutes ? "⚠️ " : "✅";
|
|
console.log(
|
|
`${status} ${scenarioName.padEnd(35)} | Init: ${initializationTime.toFixed(2).padStart(8)}ms | Path: ${stats.totalTime.toFixed(2).padStart(9)}ms | Dist: ${totalDistance.toString().padStart(7)} tiles | Routes: ${stats.successfulRoutes}/${stats.totalRoutes}`,
|
|
);
|
|
}
|
|
|
|
return {
|
|
initializationTime,
|
|
totalTime: stats.totalTime,
|
|
totalDistance: totalDistance,
|
|
};
|
|
}
|
|
|
|
function printUsage() {
|
|
console.log(`
|
|
Usage:
|
|
npx tsx tests/pathfinding/benchmark/run.ts [<scenario> [<adapter>]]
|
|
npx tsx tests/pathfinding/benchmark/run.ts --synthetic <map-name> [<adapter>]
|
|
npx tsx tests/pathfinding/benchmark/run.ts --synthetic --all [<adapter>]
|
|
|
|
Arguments:
|
|
<scenario> Name of the scenario to benchmark (default: "default" -> giantworldmap with handpicked ports)
|
|
<adapter> Pathfinding adapter: "hpa" (default), "hpa.cached", "legacy"
|
|
--silent Minimize output, only print summary lines
|
|
--synthetic Run synthetic scenarios
|
|
--all Run all synthetic scenarios (requires --synthetic)
|
|
|
|
Examples:
|
|
npx tsx tests/pathfinding/benchmark/run.ts
|
|
npx tsx tests/pathfinding/benchmark/run.ts default legacy
|
|
npx tsx tests/pathfinding/benchmark/run.ts --synthetic --all
|
|
npx tsx tests/pathfinding/benchmark/run.ts --synthetic iceland legacy
|
|
|
|
Available synthetic scenarios:
|
|
Run 'ls tests/pathfinding/benchmark/scenarios/synthetic' to see all available scenarios
|
|
`);
|
|
}
|
|
|
|
async function main() {
|
|
const args = process.argv.slice(2);
|
|
|
|
if (args.includes("--help") || args.includes("-h")) {
|
|
printUsage();
|
|
process.exit(0);
|
|
}
|
|
|
|
const isSynthetic = args.includes("--synthetic");
|
|
const isAll = args.includes("--all");
|
|
const isSilent = args.includes("--silent");
|
|
const nonFlagArgs = args.filter((arg) => !arg.startsWith("--"));
|
|
|
|
if (isSynthetic) {
|
|
if (isAll) {
|
|
// Run all synthetic scenarios
|
|
const adapterName = nonFlagArgs[0] || DEFAULT_ADAPTER;
|
|
|
|
// Find all synthetic scenario files
|
|
const scenarioFiles = readdirSync(syntheticScenariosDir)
|
|
.filter((file) => file.endsWith(".ts"))
|
|
.map((file) => file.replace(".ts", ""))
|
|
.sort();
|
|
|
|
console.log(
|
|
`Running ${scenarioFiles.length} synthetic scenarios with ${adapterName} adapter...`,
|
|
);
|
|
console.log(``);
|
|
|
|
const results: {
|
|
initializationTime: number;
|
|
totalTime: number;
|
|
totalDistance: number;
|
|
}[] = [];
|
|
|
|
for (let i = 0; i < scenarioFiles.length; i++) {
|
|
const mapName = scenarioFiles[i];
|
|
const scenarioName = `synthetic/${mapName}`;
|
|
const result = await runScenario(adapterName, scenarioName, {
|
|
silent: true,
|
|
iterations: 1,
|
|
});
|
|
results.push(result);
|
|
}
|
|
|
|
console.log(``);
|
|
console.log(`Completed ${scenarioFiles.length} scenarios`);
|
|
console.log(
|
|
`Total Initialization Time: ${results.reduce((sum, r) => sum + r.initializationTime, 0).toFixed(2)}ms`,
|
|
);
|
|
console.log(
|
|
`Total Pathfinding Time: ${results.reduce((sum, r) => sum + r.totalTime, 0).toFixed(2)}ms`,
|
|
);
|
|
console.log(
|
|
`Total Distance: ${results.reduce((sum, r) => sum + r.totalDistance, 0)} tiles`,
|
|
);
|
|
} else if (nonFlagArgs.length >= 1) {
|
|
// Run single synthetic scenario
|
|
const mapName = nonFlagArgs[0];
|
|
const adapterName = nonFlagArgs[1] || DEFAULT_ADAPTER;
|
|
const scenarioName = `synthetic/${mapName}`;
|
|
|
|
await runScenario(adapterName, scenarioName, { silent: isSilent });
|
|
} else {
|
|
console.error("Error: --synthetic requires a map name or --all flag");
|
|
printUsage();
|
|
process.exit(1);
|
|
}
|
|
} else {
|
|
// Standard mode with positional arguments
|
|
const scenarioName = nonFlagArgs[0] || DEFAULT_SCENARIO;
|
|
const adapterName = nonFlagArgs[1] || DEFAULT_ADAPTER;
|
|
|
|
await runScenario(adapterName, scenarioName, { silent: isSilent });
|
|
}
|
|
}
|
|
|
|
main().catch((error) => {
|
|
console.error("Fatal error:", error);
|
|
process.exit(1);
|
|
});
|