mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-10 10:14:38 +00:00
Evan Pelle
a7f992e9b0
Restructure the single src/ tree into an npm-workspaces monorepo under
packages/, rename core -> engine, extract a types-only core-public layer,
and break the pre-existing engine -> client dependency cycle.
Structure (packages/):
core-public public API/wire schemas + shared enums (clean leaf)
shared framework-agnostic helpers (clean leaf)
engine deterministic simulation (was src/core)
client rendering/UI (was src/client)
server coordination (was src/server)
Dependency DAG: engine -> {core-public, shared}; client -> {core-public,
shared, engine}; server -> {core-public, engine}.
- npm workspaces: root package.json workspaces + per-package package.json;
tsconfig.base.json holds shared options + path aliases
(core-public/* shared/* engine/* client/* server/*) resolved uniformly by
tsc, Vite (resolve.tsconfigPaths), Vitest, and tsx. Lockfile regenerated.
- core-public: moved Schemas/ApiSchemas/CosmeticSchemas/StatsSchemas/
ClanApiSchemas/WorkerSchemas/Base64/PatternDecoder; extracted the enums
(GameTypes), GameEvent type, emoji table, and GraphicsOverrides schema.
Engine re-exports the moved enums/types so existing imports keep working.
- Broke engine -> client cycle:
- renderNumber/renderTroops -> shared/format
- NameBoxCalculator moved into engine
- username validation returns translation key + params; client translates
- applyStateUpdate moved to client (operates on the render-only PlayerState)
- Config/UnitGrid/execution-Util/GameImpl now use structural read
interfaces (engine/game/ReadViews: PlayerLike/UnitLike/GameLike) instead
of importing client view classes; client imports view classes from a new
client/view barrel; deleted the engine/game/GameView re-export shim.
- Build/deploy updated: vite.config, index.html, eslint, Dockerfile
(copies packages/ + tsconfig.base.json before npm ci), .vscode, tests.
Verified: tsc --noEmit clean; 1364 + 65 tests pass; production vite build
succeeds; engine has zero client/server imports; core-public and shared are
dependency leaves.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
129 lines
4.3 KiB
TypeScript
129 lines
4.3 KiB
TypeScript
import { AllianceRequestExecution } from "engine/execution/alliance/AllianceRequestExecution";
|
|
import { DonateGoldExecution } from "engine/execution/DonateGoldExecution";
|
|
import { Game, Player, PlayerType } from "engine/game/Game";
|
|
import { playerInfo, setup } from "./util/Setup";
|
|
|
|
let game: Game;
|
|
let player1: Player;
|
|
let player2: Player;
|
|
|
|
describe("Alliance Donation", () => {
|
|
beforeEach(async () => {
|
|
game = await setup(
|
|
"plains",
|
|
{
|
|
infiniteGold: false,
|
|
instantBuild: true,
|
|
infiniteTroops: false,
|
|
donateGold: true,
|
|
donateTroops: true,
|
|
},
|
|
[
|
|
playerInfo("player1", PlayerType.Human),
|
|
playerInfo("player2", PlayerType.Human),
|
|
],
|
|
);
|
|
|
|
player1 = game.player("player1");
|
|
player1.conquer(game.ref(0, 0));
|
|
player1.addGold(1000n);
|
|
player1.addTroops(1000);
|
|
|
|
player2 = game.player("player2");
|
|
player2.conquer(game.ref(0, 1));
|
|
player2.addGold(100n);
|
|
player2.addTroops(100);
|
|
});
|
|
|
|
test("Can donate gold after alliance formed by reply", () => {
|
|
game.addExecution(new AllianceRequestExecution(player1, player2.id()));
|
|
game.executeNextTick();
|
|
|
|
game.addExecution(new AllianceRequestExecution(player2, player1.id()));
|
|
game.executeNextTick();
|
|
|
|
expect(player1.isAlliedWith(player2)).toBeTruthy();
|
|
expect(player2.isAlliedWith(player1)).toBeTruthy();
|
|
expect(player1.isFriendly(player2)).toBeTruthy();
|
|
expect(player2.isFriendly(player1)).toBeTruthy();
|
|
|
|
expect(player1.canDonateGold(player2)).toBeTruthy();
|
|
const goldBefore = player2.gold();
|
|
const success = player1.donateGold(player2, 100n);
|
|
expect(success).toBeTruthy();
|
|
expect(player2.gold()).toBe(goldBefore + 100n);
|
|
});
|
|
|
|
test("Can donate troops after alliance formed by reply", () => {
|
|
game.addExecution(new AllianceRequestExecution(player1, player2.id()));
|
|
game.executeNextTick();
|
|
|
|
game.addExecution(new AllianceRequestExecution(player2, player1.id()));
|
|
game.executeNextTick();
|
|
|
|
expect(player1.isAlliedWith(player2)).toBeTruthy();
|
|
expect(player2.isAlliedWith(player1)).toBeTruthy();
|
|
|
|
expect(player1.canDonateTroops(player2)).toBeTruthy();
|
|
const troopsBefore = player2.troops();
|
|
const success = player1.donateTroops(player2, 100);
|
|
expect(success).toBeTruthy();
|
|
expect(player2.troops()).toBe(troopsBefore + 100);
|
|
});
|
|
|
|
test("Can donate gold after alliance formed by mutual request", () => {
|
|
game.addExecution(new AllianceRequestExecution(player1, player2.id()));
|
|
game.executeNextTick();
|
|
|
|
game.addExecution(new AllianceRequestExecution(player2, player1.id()));
|
|
game.executeNextTick();
|
|
|
|
expect(player1.isAlliedWith(player2)).toBeTruthy();
|
|
expect(player2.isAlliedWith(player1)).toBeTruthy();
|
|
expect(player1.isFriendly(player2)).toBeTruthy();
|
|
expect(player2.isFriendly(player1)).toBeTruthy();
|
|
|
|
expect(player1.canDonateGold(player2)).toBeTruthy();
|
|
const goldBefore = player2.gold();
|
|
const success = player1.donateGold(player2, 100n);
|
|
expect(success).toBeTruthy();
|
|
expect(player2.gold()).toBe(goldBefore + 100n);
|
|
});
|
|
|
|
test("Can donate troops after alliance formed by mutual request", () => {
|
|
game.addExecution(new AllianceRequestExecution(player1, player2.id()));
|
|
game.executeNextTick();
|
|
|
|
game.addExecution(new AllianceRequestExecution(player2, player1.id()));
|
|
game.executeNextTick();
|
|
|
|
expect(player1.isAlliedWith(player2)).toBeTruthy();
|
|
expect(player2.isAlliedWith(player1)).toBeTruthy();
|
|
|
|
expect(player1.canDonateTroops(player2)).toBeTruthy();
|
|
const troopsBefore = player2.troops();
|
|
const success = player1.donateTroops(player2, 100);
|
|
expect(success).toBeTruthy();
|
|
expect(player2.troops()).toBe(troopsBefore + 100);
|
|
});
|
|
|
|
test("Can donate immediately after accepting alliance (race condition)", () => {
|
|
game.addExecution(new AllianceRequestExecution(player1, player2.id()));
|
|
game.executeNextTick();
|
|
|
|
const goldBefore = player2.gold();
|
|
game.addExecution(new AllianceRequestExecution(player2, player1.id()));
|
|
game.addExecution(new DonateGoldExecution(player1, player2.id(), 100));
|
|
|
|
game.executeNextTick();
|
|
|
|
expect(player1.isAlliedWith(player2)).toBeTruthy();
|
|
expect(player2.isAlliedWith(player1)).toBeTruthy();
|
|
|
|
game.executeNextTick();
|
|
|
|
// Donation should have succeeded
|
|
expect(player2.gold()).toBe(goldBefore + 100n);
|
|
});
|
|
});
|