mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 09:50:43 +00:00
Evan
3de5fb4204
**Add approved & assigned issue number here:** N/A — maintainer refactor. ## Description: Makes each map's `info.json` the single source of truth for map metadata — adding a map is now a folder with `image.png` + `info.json`, a `gen-maps` run, and an en.json display name. **info.json / manifest.json carry full map metadata.** Every `map-generator/assets/maps/<map>/info.json` declares `id` (the `GameMapType` enum key), `name` (the enum value — wire format, unchanged for all 94 maps), `translation_key`, `categories`, and `multiplayer_frequency` (the public-playlist weight that used to be the `FREQUENCY` record in MapPlaylist.ts). The generator validates everything and mirrors it into `resources/maps/<map>/manifest.json`. 23 stale info.json `name` values were normalized to the canonical enum value; enum values are byte-identical, so replays and stored game configs are unaffected. **The generator emits the TypeScript and discovers maps itself.** New `map-generator/codegen.go` generates `src/core/game/Maps.gen.ts` (`GameMapType`, `GameMapName`, `mapCategories`, `mapTranslationKeys`, `multiplayerFrequency` — now a full `Record<GameMapName, number>`, killing the old `Partial`) on every run; `Game.ts` re-exports it. The hardcoded map registry in `main.go` is gone — maps are auto-discovered from the `assets/maps` / `assets/test_maps` directories. MapConsistency tests fail with a "run `npm run gen-maps`" message if info.json, manifest.json, and Maps.gen.ts drift. The tracked `map-generator/map-generator` binary is rebuilt to match. **New categories: continents + world/cosmic/tournament/other, multi-category support.** `continental`/`regional`/`fantasy`/`arcade` are replaced by `featured`, `world`, `europe`, `asia`, `north_america`, `africa`, `south_america`, `oceania`, `antarctica`, `cosmic`, `tournament`, and `other`. Maps can list multiple categories, so straddlers (Black Sea, Bosphorus, Caucasus, Between Two Seas, Bering Sea/Strait, Mena, Strait of Gibraltar, Hawaii, Arctic) appear under both regions. Featured is itself a category (same 7 maps as before). MapPlaylist keeps its arcade exclusion via an explicit set. **Map picker UI.** Two tabs: **Featured** (default — featured maps plus a Favorites section when maps are starred) and **All** (one prominent collapsible bar per category with a map count, collapsed by default). The selected map is prepended to the featured grid when it lives elsewhere. `getMapName()` resolves through the generated `mapTranslationKeys`, which also fixes tourney maps never resolving a valid translation key. ## Please complete the following: - [ ] I have added screenshots for all UI updates (maintainer change — picker described above) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: evanpelle 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
90 lines
1.6 KiB
JSON
90 lines
1.6 KiB
JSON
{
|
|
"categories": ["asia"],
|
|
"id": "StraitOfMalacca",
|
|
"map": {
|
|
"height": 1644,
|
|
"num_land_tiles": 865820,
|
|
"width": 1832
|
|
},
|
|
"map16x": {
|
|
"height": 411,
|
|
"num_land_tiles": 50740,
|
|
"width": 458
|
|
},
|
|
"map4x": {
|
|
"height": 822,
|
|
"num_land_tiles": 211494,
|
|
"width": 916
|
|
},
|
|
"multiplayer_frequency": 4,
|
|
"name": "Strait Of Malacca",
|
|
"nations": [
|
|
{
|
|
"coordinates": [1268, 730],
|
|
"flag": "sg",
|
|
"name": "Singapore"
|
|
},
|
|
{
|
|
"coordinates": [862, 41],
|
|
"flag": "th",
|
|
"name": "Thailand"
|
|
},
|
|
{
|
|
"coordinates": [210, 243],
|
|
"flag": "Aceh",
|
|
"name": "Aceh"
|
|
},
|
|
{
|
|
"coordinates": [1053, 333],
|
|
"flag": "my",
|
|
"name": "Malaysia"
|
|
},
|
|
{
|
|
"coordinates": [596, 573],
|
|
"flag": "id",
|
|
"name": "North Sumatra"
|
|
},
|
|
{
|
|
"coordinates": [797, 1002],
|
|
"flag": "id",
|
|
"name": "West Sumatra"
|
|
},
|
|
{
|
|
"coordinates": [956, 743],
|
|
"flag": "id",
|
|
"name": "Riau"
|
|
},
|
|
{
|
|
"coordinates": [1644, 1265],
|
|
"flag": "id",
|
|
"name": "Bangka Belitung"
|
|
},
|
|
{
|
|
"coordinates": [1419, 1636],
|
|
"flag": "id",
|
|
"name": "Lampung"
|
|
},
|
|
{
|
|
"coordinates": [1084, 1414],
|
|
"flag": "id",
|
|
"name": "Bengkulu"
|
|
},
|
|
{
|
|
"coordinates": [1366, 1303],
|
|
"flag": "id",
|
|
"name": "South Sumatra"
|
|
},
|
|
{
|
|
"coordinates": [1167, 1071],
|
|
"flag": "id",
|
|
"name": "Jambi"
|
|
},
|
|
{
|
|
"coordinates": [1383, 938],
|
|
"flag": "id",
|
|
"name": "Riau Islands"
|
|
}
|
|
],
|
|
"translation_key": "map.straitofmalacca"
|
|
}
|