mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 10:10:55 +00:00
Evan
182d008ddd
**Add approved & assigned issue number here:** N/A — maintainer follow-up to #4227. ## Description: Follow-up to #4227, finishing the "info.json is the single source of truth" refactor. **Maps.gen.ts now generates one `MapInfo` interface and a `maps` list** instead of parallel lookup records. `mapCategories`, `mapTranslationKeys`, and `multiplayerFrequency` are gone — consumers read the list directly (`map.categories`, `map.translationKey`, `map.multiplayerFrequency`). MapPicker got simpler in the process: it renders from `MapInfo` objects, so the reverse `Object.entries(GameMapType)` lookup to recover the enum key is gone. The featured-rank sort moved out of the Go codegen into the picker, where the presentation concern belongs. **`SPECIAL_TEAM_MAPS` moves into info.json** as an optional `special_team_count` field (set on the same 17 maps with the same values). MapPlaylist derives its map from the generated list; `SPECIAL_TEAM_FORCE_CHANCE` and the frequency multiplier behavior are unchanged. **The en.json `map` section is now generated.** A new optional `display_name` field in info.json (defaulting to `name`) is written to `resources/lang/en.json` by the generator, preserving the section's non-map UI keys (`map`, `featured`, `all`, `favorites`, `random`). The 8 maps whose English display name intentionally differs from the frozen enum value (e.g. `MENA`, `Milky Way`, `Europe (Classic)`, `Baikal (Nuke Wars)`) declare it via `display_name`, so no display text changes. The section is emitted alphabetically; since #4232 already sorted en.json and every value matches, regeneration is byte-identical and this PR has no en.json diff. Other languages remain Crowdin-managed. The generator also now validates `translation_key` is exactly `map.<folder>` and `special_team_count >= 2`. MapConsistency tests compare info.json directly against the generated list and the en.json section, and fail with a "run `npm run gen-maps`" message on drift. No behavior changes: enum values, playlist frequencies, special-team counts, featured order, and display names are all byte-identical. ## Please complete the following: - [x] I have added screenshots for all UI updates (no UI changes — internal refactor, rendering output identical) - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: evanpelle 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
152 lines
2.6 KiB
JSON
152 lines
2.6 KiB
JSON
{
|
|
"categories": ["europe", "asia"],
|
|
"id": "BosphorusStraits",
|
|
"map": {
|
|
"height": 612,
|
|
"num_land_tiles": 382332,
|
|
"width": 1000
|
|
},
|
|
"map16x": {
|
|
"height": 153,
|
|
"num_land_tiles": 22523,
|
|
"width": 250
|
|
},
|
|
"map4x": {
|
|
"height": 306,
|
|
"num_land_tiles": 93711,
|
|
"width": 500
|
|
},
|
|
"multiplayer_frequency": 3,
|
|
"name": "Bosphorus Straits",
|
|
"nations": [
|
|
{
|
|
"coordinates": [564, 245],
|
|
"flag": "tr",
|
|
"name": "Beykoz"
|
|
},
|
|
{
|
|
"coordinates": [820, 209],
|
|
"flag": "tr",
|
|
"name": "Sile"
|
|
},
|
|
{
|
|
"coordinates": [700, 316],
|
|
"flag": "tr",
|
|
"name": "Çekmeköy"
|
|
},
|
|
{
|
|
"coordinates": [800, 438],
|
|
"flag": "tr",
|
|
"name": "Pendik"
|
|
},
|
|
{
|
|
"coordinates": [797, 566],
|
|
"flag": "tr",
|
|
"name": "Tuzla"
|
|
},
|
|
{
|
|
"coordinates": [486, 381],
|
|
"flag": "tr",
|
|
"name": "Üsküdar"
|
|
},
|
|
{
|
|
"coordinates": [534, 425],
|
|
"flag": "tr",
|
|
"name": "Kadiköy"
|
|
},
|
|
{
|
|
"coordinates": [559, 568],
|
|
"flag": "tr",
|
|
"name": "Adalar"
|
|
},
|
|
{
|
|
"coordinates": [635, 500],
|
|
"flag": "tr",
|
|
"name": "Maltepe"
|
|
},
|
|
{
|
|
"coordinates": [701, 423],
|
|
"flag": "tr",
|
|
"name": "Sancaktepe"
|
|
},
|
|
{
|
|
"coordinates": [424, 394],
|
|
"flag": "tr",
|
|
"name": "Fatih"
|
|
},
|
|
{
|
|
"coordinates": [128, 46],
|
|
"flag": "tr",
|
|
"name": "Arnavutköy"
|
|
},
|
|
{
|
|
"coordinates": [965, 544],
|
|
"flag": "tr",
|
|
"name": "Kocaeli"
|
|
},
|
|
{
|
|
"coordinates": [42, 325],
|
|
"flag": "tr",
|
|
"name": "Büyükçekmece"
|
|
},
|
|
{
|
|
"coordinates": [336, 175],
|
|
"flag": "tr",
|
|
"name": "Eyüpsultan"
|
|
},
|
|
{
|
|
"coordinates": [459, 157],
|
|
"flag": "tr",
|
|
"name": "Sariyer"
|
|
},
|
|
{
|
|
"coordinates": [477, 297],
|
|
"flag": "tr",
|
|
"name": "Besiktas"
|
|
},
|
|
{
|
|
"coordinates": [171, 379],
|
|
"flag": "tr",
|
|
"name": "Avcilar"
|
|
},
|
|
{
|
|
"coordinates": [308, 412],
|
|
"flag": "tr",
|
|
"name": "Bakirköy"
|
|
},
|
|
{
|
|
"coordinates": [263, 283],
|
|
"flag": "tr",
|
|
"name": "Basaksehir"
|
|
},
|
|
{
|
|
"coordinates": [402, 272],
|
|
"flag": "tr",
|
|
"name": "Sultangazi"
|
|
},
|
|
{
|
|
"coordinates": [130, 270],
|
|
"flag": "tr",
|
|
"name": "Esenyurt"
|
|
}
|
|
],
|
|
"special_team_count": 2,
|
|
"teamGameSpawnAreas": {
|
|
"2": [
|
|
{
|
|
"height": 612,
|
|
"width": 500,
|
|
"x": 0,
|
|
"y": 0
|
|
},
|
|
{
|
|
"height": 612,
|
|
"width": 500,
|
|
"x": 500,
|
|
"y": 0
|
|
}
|
|
]
|
|
},
|
|
"translation_key": "map.bosphorusstraits"
|
|
}
|