Files
OpenFrontIO/tests/PlayerImpl.test.ts
evanpelle ac9a9ec253 fix unit upgrade not considering cost (#1434)
## Description:

bugfix: The price was not considered when checking it upgrading a unit
was allowed.
Also refacted and cleaned up the code a bit.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

evan
2025-07-14 16:32:05 -07:00

81 lines
2.2 KiB
TypeScript

import {
Game,
Player,
PlayerInfo,
PlayerType,
UnitType,
} from "../src/core/game/Game";
import { setup } from "./util/Setup";
let game: Game;
let player: Player;
describe("PlayerImpl", () => {
beforeEach(async () => {
game = await setup(
"plains",
{
instantBuild: true,
},
[new PlayerInfo("player", PlayerType.Human, null, "player_id")],
);
while (game.inSpawnPhase()) {
game.executeNextTick();
}
player = game.player("player_id");
player.addGold(BigInt(1000000));
game.config().structureMinDist = () => 10;
});
test("City can be upgraded", () => {
const city = player.buildUnit(UnitType.City, game.ref(0, 0), {});
const buCity = player
.buildableUnits(game.ref(0, 0))
.find((bu) => bu.type === UnitType.City);
expect(buCity).toBeDefined();
expect(buCity!.canUpgrade).toBe(city.id());
});
test("DefensePost cannot be upgraded", () => {
player.buildUnit(UnitType.DefensePost, game.ref(0, 0), {});
const buDefensePost = player
.buildableUnits(game.ref(0, 0))
.find((bu) => bu.type === UnitType.DefensePost);
expect(buDefensePost).toBeDefined();
expect(buDefensePost!.canUpgrade).toBeFalsy();
});
test("City can be upgraded from another city", () => {
const city = player.buildUnit(UnitType.City, game.ref(0, 0), {});
const cityToUpgrade = player.findUnitToUpgrade(
UnitType.City,
game.ref(0, 1),
);
expect(cityToUpgrade).toBeTruthy();
if (cityToUpgrade === false) {
return;
}
expect(cityToUpgrade.id()).toBe(city.id());
});
test("City cannot be upgraded when too far away", () => {
player.buildUnit(UnitType.City, game.ref(0, 0), {});
const cityToUpgrade = player.findUnitToUpgrade(
UnitType.City,
game.ref(50, 50),
);
expect(cityToUpgrade).toBe(false);
});
test("Unit cannot be upgraded when not enough gold", () => {
player.buildUnit(UnitType.City, game.ref(0, 0), {});
player.removeGold(BigInt(1000000));
const cityToUpgrade = player.findUnitToUpgrade(
UnitType.City,
game.ref(0, 1),
);
expect(cityToUpgrade).toBe(false);
});
});