Files
OpenFrontIO/tests/DeleteUnitExecution.test.ts
Kipstz 298759b7a2 Add button for remove building (#1609)
## Description:

Added a red delete button with trash can icon to the right-click radial
menu that allows players to voluntarily delete their own units.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I have read and accepted the CLA agreement (only required once).

## Please put your Discord username so you can be contacted if a bug or
regression is found:

Kipstz

<img width="286" height="209" alt="image"
src="https://github.com/user-attachments/assets/85142be3-2aa5-4c84-ab30-0c68289c8f85"
/>

---------

Co-authored-by: Drills Kibo <59177241+drillskibo@users.noreply.github.com>
2025-08-05 05:22:07 +00:00

124 lines
3.4 KiB
TypeScript

import { DeleteUnitExecution } from "../src/core/execution/DeleteUnitExecution";
import { SpawnExecution } from "../src/core/execution/SpawnExecution";
import {
Game,
Player,
PlayerInfo,
PlayerType,
Unit,
UnitType,
} from "../src/core/game/Game";
import { TileRef } from "../src/core/game/GameMap";
import { setup } from "./util/Setup";
describe("DeleteUnitExecution Security Tests", () => {
let game: Game;
let player: Player;
let enemyPlayer: Player;
let unit: Unit;
beforeEach(async () => {
game = await setup("plains", {
infiniteGold: true,
instantBuild: true,
infiniteTroops: true,
});
const player1Info = new PlayerInfo(
"TestPlayer",
PlayerType.Human,
null,
"TestPlayer",
);
const player2Info = new PlayerInfo(
"EnemyPlayer",
PlayerType.Human,
null,
"EnemyPlayer",
);
game.addPlayer(player1Info);
game.addPlayer(player2Info);
const playerSpawn: TileRef = game.ref(0, 10);
const enemySpawn: TileRef = game.ref(0, 15);
game.addExecution(
new SpawnExecution(game.player(player1Info.id).info(), playerSpawn),
new SpawnExecution(game.player(player2Info.id).info(), enemySpawn),
);
while (game.inSpawnPhase()) {
game.executeNextTick();
}
player = game.player(player1Info.id);
enemyPlayer = game.player(player2Info.id);
const playerTiles = Array.from(player.tiles());
if (playerTiles.length === 0) {
throw new Error("Player has no tiles");
}
const spawnTile = playerTiles[0];
unit = player.buildUnit(UnitType.City, spawnTile, {});
const tileOwner = game.owner(unit.tile());
if (!tileOwner.isPlayer() || tileOwner.id() !== player.id()) {
throw new Error("Unit is not on player's territory");
}
});
describe("Security Validations", () => {
it("should prevent deleting units not owned by player", () => {
const enemyUnit = enemyPlayer.buildUnit(
UnitType.City,
Array.from(enemyPlayer.tiles())[0],
{},
);
const execution = new DeleteUnitExecution(player, enemyUnit.id());
execution.init(game, 0);
expect(execution.isActive()).toBe(false);
});
it("should prevent deleting units on enemy territory", () => {
const enemyTiles = Array.from(enemyPlayer.tiles());
if (enemyTiles.length > 0) {
unit.move(enemyTiles[0]);
const execution = new DeleteUnitExecution(player, unit.id());
execution.init(game, 0);
expect(execution.isActive()).toBe(false);
}
});
it("should prevent deleting units during spawn phase", () => {
jest.spyOn(game, "inSpawnPhase").mockReturnValue(true);
const execution = new DeleteUnitExecution(player, unit.id());
execution.init(game, 0);
expect(execution.isActive()).toBe(false);
});
it("should allow deleting the last city (suicide)", () => {
jest.spyOn(game, "inSpawnPhase").mockReturnValue(false);
const execution = new DeleteUnitExecution(player, unit.id());
execution.init(game, 0);
expect(unit.isActive()).toBe(false);
});
it("should allow deleting units when all conditions are met", () => {
jest.spyOn(game, "inSpawnPhase").mockReturnValue(false);
const execution = new DeleteUnitExecution(player, unit.id());
execution.init(game, 0);
expect(unit.isActive()).toBe(false);
});
});
});