From fd193d2190a93d5f640dee4acd01b2039b53ea1b Mon Sep 17 00:00:00 2001 From: Ghis <23282302+ghisloufou@users.noreply.github.com> Date: Tue, 10 Jun 2025 22:39:41 +0200 Subject: [PATCH] Fix non valid SafeString flag codes (#1135) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description: Removed unicode in the following flag file names to prevent error, which lead to not be able to start a game with it. - Ceará - 1_Northern Uí Néill - Pará - São Paulo - 1_Southern Uí Néill related to https://github.com/openfrontio/OpenFrontIO/pull/1133 ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [x] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors ## Please put your Discord username so you can be contacted if a bug or regression is found: ghisloufou --- ...1_Northern Uí Néill.svg => 1_Northern Ui Neill.svg} | 0 ...1_Southern Uí Néill.svg => 1_Southern Ui Neill.svg} | 0 resources/flags/{Ceará.svg => Ceara.svg} | 0 resources/flags/{Pará.svg => Para.svg} | 0 resources/flags/{São Paulo.svg => Sao Paulo.svg} | 0 resources/flags/para.svg | 3 --- resources/maps/Britannia.json | 4 ++-- src/client/data/countries.json | 10 +++++----- 8 files changed, 7 insertions(+), 10 deletions(-) rename resources/flags/{1_Northern Uí Néill.svg => 1_Northern Ui Neill.svg} (100%) rename resources/flags/{1_Southern Uí Néill.svg => 1_Southern Ui Neill.svg} (100%) rename resources/flags/{Ceará.svg => Ceara.svg} (100%) rename resources/flags/{Pará.svg => Para.svg} (100%) rename resources/flags/{São Paulo.svg => Sao Paulo.svg} (100%) delete mode 100644 resources/flags/para.svg diff --git a/resources/flags/1_Northern Uí Néill.svg b/resources/flags/1_Northern Ui Neill.svg similarity index 100% rename from resources/flags/1_Northern Uí Néill.svg rename to resources/flags/1_Northern Ui Neill.svg diff --git a/resources/flags/1_Southern Uí Néill.svg b/resources/flags/1_Southern Ui Neill.svg similarity index 100% rename from resources/flags/1_Southern Uí Néill.svg rename to resources/flags/1_Southern Ui Neill.svg diff --git a/resources/flags/Ceará.svg b/resources/flags/Ceara.svg similarity index 100% rename from resources/flags/Ceará.svg rename to resources/flags/Ceara.svg diff --git a/resources/flags/Pará.svg b/resources/flags/Para.svg similarity index 100% rename from resources/flags/Pará.svg rename to resources/flags/Para.svg diff --git a/resources/flags/São Paulo.svg b/resources/flags/Sao Paulo.svg similarity index 100% rename from resources/flags/São Paulo.svg rename to resources/flags/Sao Paulo.svg diff --git a/resources/flags/para.svg b/resources/flags/para.svg deleted file mode 100644 index aae5eb835..000000000 --- a/resources/flags/para.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - \ No newline at end of file diff --git a/resources/maps/Britannia.json b/resources/maps/Britannia.json index 79c5533ac..614d3615a 100644 --- a/resources/maps/Britannia.json +++ b/resources/maps/Britannia.json @@ -115,7 +115,7 @@ "coordinates": [564, 845], "name": "Southern Uí Néill", "strength": 3, - "flag": "1_Southern Uí Néill" + "flag": "1_Southern Ui Neill" }, { "coordinates": [639, 680], @@ -133,7 +133,7 @@ "coordinates": [416, 678], "name": "Northern Uí Néill", "strength": 3, - "flag": "1_Northern Uí Néill" + "flag": "1_Northern Ui Neill" }, { "coordinates": [1869, 1308], diff --git a/src/client/data/countries.json b/src/client/data/countries.json index 043f2963b..61b7c0251 100644 --- a/src/client/data/countries.json +++ b/src/client/data/countries.json @@ -404,7 +404,7 @@ "name": "Cayman Islands" }, { - "code": "Ceará", + "code": "Ceara", "continent": "South America", "name": "Ceará" }, @@ -1501,7 +1501,7 @@ "name": "Northern Mariana Islands" }, { - "code": "1_Northern Uí Néill", + "code": "1_Northern Ui Neill", "continent": "Europe", "name": "Northern Uí Néill" }, @@ -1566,7 +1566,7 @@ "name": "Papua New Guinea" }, { - "code": "Pará", + "code": "Para", "continent": "South America", "name": "Pará" }, @@ -1803,7 +1803,7 @@ "name": "Sao Tome and Principe" }, { - "code": "São Paulo", + "code": "Sao Paulo", "continent": "South America", "name": "São Paulo" }, @@ -1941,7 +1941,7 @@ "name": "South Sudan" }, { - "code": "1_Southern Uí Néill", + "code": "1_Southern Ui Neill", "continent": "Europe", "name": "Southern Uí Néill" },