From f5cba9a495acf867c774328adeeb1fe775af8978 Mon Sep 17 00:00:00 2001
From: Aotumuri <aotumuri.yt@gmail.com>
Date: Tue, 3 Feb 2026 22:26:47 +0900
Subject: [PATCH] fix: remove incorrect host display in JoinLobbyModal (Public
 game) (#3099)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

## Description:
Hide the host badge when joining public lobbies

before
<img width="802" height="635" alt="スクリーンショット 2026-02-03 21 45 45"
src="https://github.com/user-attachments/assets/2b8bd5a0-3023-4bd3-9042-1bbd0649e499"
/>

after
<img width="668" height="702" alt="スクリーンショット 2026-02-03 21 44 00"
src="https://github.com/user-attachments/assets/65eb9b66-99b0-46ce-a786-55974a443010"
/>


## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:
aotumuri
---
 src/client/JoinLobbyModal.ts | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/src/client/JoinLobbyModal.ts b/src/client/JoinLobbyModal.ts
index 20e0e79b0..59ee5b48a 100644
--- a/src/client/JoinLobbyModal.ts
+++ b/src/client/JoinLobbyModal.ts
@@ -55,6 +55,10 @@ export class JoinLobbyModal extends BaseModal {
   private countdownTimerId: number | null = null;
   private handledJoinTimeout = false;
 
+  private isPrivateLobby(): boolean {
+    return this.gameConfig?.gameType === GameType.Private;
+  }
+
   private readonly handleLobbyInfo = (event: LobbyInfoEvent) => {
     const lobby = event.lobby;
     if (!this.currentLobbyId || lobby.gameID !== this.currentLobbyId) {
@@ -91,6 +95,9 @@ export class JoinLobbyModal extends BaseModal {
           : translateText("public_lobby.started");
     const maxPlayers = this.gameConfig?.maxPlayers ?? 0;
     const playerCount = this.playerCount;
+    const hostClientID = this.isPrivateLobby()
+      ? (this.lobbyCreatorClientID ?? "")
+      : "";
     const content = html`
       <div
         class="h-full flex flex-col bg-black/60 backdrop-blur-md rounded-2xl border border-white/10 overflow-hidden select-none"
@@ -100,8 +107,7 @@ export class JoinLobbyModal extends BaseModal {
           onBack: () => this.closeAndLeave(),
           ariaLabel: translateText("common.close"),
           rightContent:
-            this.currentLobbyId &&
-            this.gameConfig?.gameType === GameType.Private
+            this.currentLobbyId && this.isPrivateLobby()
               ? html`
                   <copy-button .lobbyId=${this.currentLobbyId}></copy-button>
                 `
@@ -129,7 +135,7 @@ export class JoinLobbyModal extends BaseModal {
                         class="mt-6"
                         .gameMode=${this.gameConfig?.gameMode ?? GameMode.FFA}
                         .clients=${this.players}
-                        .lobbyCreatorClientID=${this.lobbyCreatorClientID}
+                        .lobbyCreatorClientID=${hostClientID}
                         .currentClientID=${this.currentClientID}
                         .teamCount=${this.gameConfig?.playerTeams ?? 2}
                         .nationCount=${this.nationCount}
@@ -143,7 +149,7 @@ export class JoinLobbyModal extends BaseModal {
               `}
         </div>
 
-        ${this.gameConfig?.gameType === GameType.Private
+        ${this.isPrivateLobby()
           ? html`
               <div
                 class="p-6 pt-4 border-t border-white/10 bg-black/20 shrink-0"
@@ -533,7 +539,6 @@ export class JoinLobbyModal extends BaseModal {
     if (lobby.clients) {
       this.players = lobby.clients;
       this.playerCount = lobby.clients.length;
-      this.lobbyCreatorClientID = lobby.clients[0]?.clientID ?? null;
     } else {
       this.players = [];
       this.playerCount = lobby.numClients ?? 0;
@@ -551,6 +556,10 @@ export class JoinLobbyModal extends BaseModal {
         this.loadNationCount();
       }
     }
+
+    this.lobbyCreatorClientID = this.isPrivateLobby()
+      ? (lobby.clients?.[0]?.clientID ?? null)
+      : null;
   }
 
   private startLobbyUpdates() {