From f228f6b1bb9345db95979b5748ab7611ab53a6fe Mon Sep 17 00:00:00 2001 From: VariableVince <24507472+VariableVince@users.noreply.github.com> Date: Mon, 24 Nov 2025 21:16:59 +0100 Subject: [PATCH] Workflows: better message for missing PR Milestone (#2510) ## Description: Make more clear who's responsible to set the milestone on a PR. The current error message raises questions about who's responsible for this, especially when the PR author doesn't have the access rights to set the Milestone. **Old message:** "Pull request must have a milestone assigned before merging." **New message:** "Reviewer must assign a Milestone to this Pull request before merging." ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: tryout33 --- .github/workflows/pr-description.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-description.yml b/.github/workflows/pr-description.yml index 941b931df..1c36a4a91 100644 --- a/.github/workflows/pr-description.yml +++ b/.github/workflows/pr-description.yml @@ -73,7 +73,7 @@ jobs: // Get the pull request data const milestone = context.payload.pull_request.milestone; if (!milestone) { - core.setFailed('❌ Pull request must have a milestone assigned before merging.'); + core.setFailed('❌ Reviewer must assign a Milestone to this Pull request before merging.'); return; } console.log(`✅ Milestone found: ${milestone.title}`);