From e216b8a22bd1eef2c8ffc945db56e2003be6d6a1 Mon Sep 17 00:00:00 2001
From: Scott Anderson <662325+scottanderson@users.noreply.github.com>
Date: Thu, 28 Aug 2025 03:22:46 -0400
Subject: [PATCH] cleanup: Nations rarely launch nukes (#1948)

## Description:

In #1860, some unused code was left behind. Remove the unused code.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
---
 src/core/execution/FakeHumanExecution.ts | 48 ------------------------
 1 file changed, 48 deletions(-)

diff --git a/src/core/execution/FakeHumanExecution.ts b/src/core/execution/FakeHumanExecution.ts
index 73c56c1ec..aaefa84de 100644
--- a/src/core/execution/FakeHumanExecution.ts
+++ b/src/core/execution/FakeHumanExecution.ts
@@ -1,6 +1,5 @@
 import {
   Cell,
-  Difficulty,
   Execution,
   Game,
   Gold,
@@ -239,53 +238,6 @@ export class FakeHumanExecution implements Execution {
     }
   }
 
-  private shouldAttack(other: Player): boolean {
-    if (this.player === null) throw new Error("not initialized");
-
-    if (this.player.isOnSameTeam(other)) {
-      return false;
-    }
-
-    const shouldAttack = this.attackChance(other);
-
-    // Consider betrayal for allies
-    if (shouldAttack && this.player.isAlliedWith(other)) {
-      return this.maybeConsiderBetrayal(other);
-    }
-
-    return shouldAttack;
-  }
-
-  private attackChance(other: Player): boolean {
-    if (this.player === null) throw new Error("not initialized");
-
-    if (this.player.isAlliedWith(other)) {
-      return this.shouldDiscourageAttack(other)
-        ? this.random.chance(200)
-        : this.random.chance(50);
-    } else {
-      return this.shouldDiscourageAttack(other) ? this.random.chance(4) : true;
-    }
-  }
-
-  private shouldDiscourageAttack(other: Player) {
-    if (other.isTraitor()) {
-      return false;
-    }
-    const difficulty = this.mg.config().gameConfig().difficulty;
-    if (
-      difficulty === Difficulty.Hard ||
-      difficulty === Difficulty.Impossible
-    ) {
-      return false;
-    }
-    if (other.type() !== PlayerType.Human) {
-      return false;
-    }
-    // Only discourage attacks on Humans who are not traitors on easy or medium difficulty.
-    return true;
-  }
-
   private maybeSendEmoji(enemy: Player) {
     if (this.player === null) throw new Error("not initialized");
     if (enemy.type() !== PlayerType.Human) return;