refactor radial, fix boat on terra nullius not working fixes (#1095)

## Description:
refactor the MenuElements to be more decoupled by passing in MenuParams.

Fix boat not working on terra nullius.

fixes #1088

## Please complete the following:

- [ ] I have added screenshots for all UI updates
- [ ] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [ ] I have added relevant tests to the test directory
- [ ] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [ ] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

<DISCORD USERNAME>
This commit is contained in:
evanpelle
2025-06-07 15:34:10 -07:00
committed by GitHub
parent 72bb78342e
commit dda9e26596
5 changed files with 288 additions and 335 deletions
@@ -1,5 +1,10 @@
import { EventBus } from "../../../core/EventBus";
import { Cell, PlayerActions, UnitType } from "../../../core/game/Game";
import {
Cell,
PlayerActions,
PlayerID,
UnitType,
} from "../../../core/game/Game";
import { TileRef } from "../../../core/game/GameMap";
import { PlayerView } from "../../../core/game/GameView";
import {
@@ -42,7 +47,7 @@ export class PlayerActionHandler {
handleBoatAttack(
player: PlayerView,
targetId: string,
targetId: PlayerID | null,
targetCell: Cell,
spawnTile: Cell | null,
) {