From d00425871d33eed14b7c222244da859e6878f01b Mon Sep 17 00:00:00 2001 From: Evan Date: Tue, 28 Apr 2026 18:35:07 -0600 Subject: [PATCH] Fix cross-browser CSS-mask CORS failures for OpenFrontLogo and SoldierIcon (#3792) ## Description: Cross-origin CSS-mask icons were failing on Chrome and Safari because mask: url(...) triggers a CORS-mode fetch (unlike plain ), and stale browser caches without ACAO break per-user. Instead change the svgs with the appropriate colors so we don't need to mask them ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: evan --- proprietary/images/OpenFrontLogo.svg | 204 +++++++++--------- resources/images/SoldierIconAquarius.svg | 8 + src/client/components/DesktopNavBar.ts | 15 +- .../graphics/layers/PlayerInfoOverlay.ts | 16 +- 4 files changed, 124 insertions(+), 119 deletions(-) create mode 100644 resources/images/SoldierIconAquarius.svg diff --git a/proprietary/images/OpenFrontLogo.svg b/proprietary/images/OpenFrontLogo.svg index 3d5d2e3ba..234064f1e 100644 --- a/proprietary/images/OpenFrontLogo.svg +++ b/proprietary/images/OpenFrontLogo.svg @@ -2,107 +2,107 @@ xmlns="http://www.w3.org/2000/svg" viewBox="0 0 1364 259" > - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + diff --git a/resources/images/SoldierIconAquarius.svg b/resources/images/SoldierIconAquarius.svg new file mode 100644 index 000000000..81a6b021c --- /dev/null +++ b/resources/images/SoldierIconAquarius.svg @@ -0,0 +1,8 @@ + + + + + + + + diff --git a/src/client/components/DesktopNavBar.ts b/src/client/components/DesktopNavBar.ts index af220e04c..8fa0e31ed 100644 --- a/src/client/components/DesktopNavBar.ts +++ b/src/client/components/DesktopNavBar.ts @@ -54,16 +54,11 @@ export class DesktopNavBar extends LitElement { >
- + OpenFront
0 ? soldierIconAquarius : soldierIcon} + alt="" + aria-hidden="true" + />↑ ${renderTroops(attackingTroops)}