From cceb7bd0fc4690a89a4d527120313f056c35ef55 Mon Sep 17 00:00:00 2001 From: VariableVince <24507472+VariableVince@users.noreply.github.com> Date: Mon, 9 Feb 2026 22:00:51 +0100 Subject: [PATCH] Fix: can't boat into AFK ally from radial menu (#3165) ## Description: Fixes issue where you can't boat into an AFK/disconnected ally from the radial menu: https://www.youtube.com/clip/UgkxRXy2Y9BrmCiQRSFJnhVFanR5NRsG9pzu ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: tryout33 --- src/client/graphics/layers/RadialMenuElements.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/client/graphics/layers/RadialMenuElements.ts b/src/client/graphics/layers/RadialMenuElements.ts index aeafdf8a1..4ced271d0 100644 --- a/src/client/graphics/layers/RadialMenuElements.ts +++ b/src/client/graphics/layers/RadialMenuElements.ts @@ -618,6 +618,7 @@ export const rootMenuElement: MenuElement = { color: COLORS.info, subMenu: (params: MenuElementParams) => { const isAllied = params.selected?.isAlliedWith(params.myPlayer); + const isDisconnected = isDisconnectedTarget(params); const tileOwner = params.game.owner(params.tile); const isOwnTerritory = @@ -629,9 +630,9 @@ export const rootMenuElement: MenuElement = { ...(isOwnTerritory ? [deleteUnitElement, allyRequestElement, buildMenuElement] : [ - isAllied ? allyBreakElement : boatMenuElement, + isAllied && !isDisconnected ? allyBreakElement : boatMenuElement, allyRequestElement, - isFriendlyTarget(params) && !isDisconnectedTarget(params) + isFriendlyTarget(params) && !isDisconnected ? donateGoldRadialElement : attackMenuElement, ]),