alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-07-21 12:55:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor cosmetics out of PlayerInfo (#1299)

Browse Source 
## Description:

Remove Cosmetics from PlayerInfo. The game engine should have no
knowledge of cosmetics since they shouldn't affect game play at all.
Instead pass player cosmetics into the GameView.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

evan
This commit is contained in:
evanpelle
2025-06-28 12:33:19 -07:00
committed by GitHub
parent 9dcceefc33
commit ca522a5937
23 changed files with 64 additions and 186 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/UnitGrid.test.ts
+4 -32
View File
@@ -11,14 +11,7 @@ async function checkRange(
const game = await setup(mapName, { infiniteGold: true, instantBuild: true });
const grid = new UnitGrid(game.map());
const player = game.addPlayer(
new PlayerInfo(
undefined,
"us",
"test_player",
PlayerType.Human,
null,
"test_id",
),
new PlayerInfo("test_player", PlayerType.Human, null, "test_id"),
);
const unitTile = game.map().ref(unitPosX, 0);
grid.addUnit(player.buildUnit(UnitType.DefensePost, unitTile, {}));
@@ -41,14 +34,7 @@ async function nearbyUnits(
const game = await setup(mapName, { infiniteGold: true, instantBuild: true });
const grid = new UnitGrid(game.map());
const player = game.addPlayer(
new PlayerInfo(
undefined,
"us",
"test_player",
PlayerType.Human,
null,
"test_id",
),
new PlayerInfo("test_player", PlayerType.Human, null, "test_id"),
);
const unitTile = game.map().ref(unitPosX, 0);
for (const unitType of unitTypes) {
@@ -122,14 +108,7 @@ describe("Unit Grid range tests", () => {
});
const grid = new UnitGrid(game.map());
const player = game.addPlayer(
new PlayerInfo(
undefined,
"us",
"test_player",
PlayerType.Human,
null,
"test_id",
),
new PlayerInfo("test_player", PlayerType.Human, null, "test_id"),
);
const unitTile = game.map().ref(0, 0);
grid.addUnit(player.buildUnit(UnitType.City, unitTile, {}));
@@ -146,14 +125,7 @@ describe("Unit Grid range tests", () => {
});
const grid = new UnitGrid(game.map());
const player = game.addPlayer(
new PlayerInfo(
undefined,
"us",
"test_player",
PlayerType.Human,
null,
"test_id",
),
new PlayerInfo("test_player", PlayerType.Human, null, "test_id"),
);
const unitType = UnitType.City;
const unitTile = game.map().ref(0, 0);