From c29fca477b8fd1663f98d07b6eda22dbbb09b71f Mon Sep 17 00:00:00 2001 From: VariableVince <24507472+VariableVince@users.noreply.github.com> Date: Fri, 20 Mar 2026 22:03:06 +0100 Subject: [PATCH] Fix(HelpModal): small updates and fixes (#3473) ## Description: - fix info icon spacing - update multiple texts to reflect current state, rewrote "ui_playeroverlay_desc" further for better readability - add text for the options menu, and change their order to reflect current button order - add missing "Stop trading" icon, is PNG so lazy load - remove uneccesary lazy loading for an SVG icon (rest of the SVGs aren't lazy loaded either) Didn't touch the rest although more incremental updates are needed following UI and other changes. Before: image image After: image image ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: tryout33 --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> --- resources/lang/en.json | 7 ++++--- src/client/HelpModal.ts | 21 +++++++++------------ 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/resources/lang/en.json b/resources/lang/en.json index 56468b246..cf3dfe2ce 100644 --- a/resources/lang/en.json +++ b/resources/lang/en.json @@ -121,12 +121,13 @@ "ui_options": "Options", "ui_options_desc": "The following elements can be found inside:", "ui_playeroverlay": "Player info overlay", - "ui_playeroverlay_desc": "When you hover over a country, the Player info overlay is displayed under Options. It shows the type of player: Human, Nation, or Tribe. A Nation's attitude towards you, ranging from Hostile to Friendly. And defending troops, gold, plus the number of Warships and various buildings the player has.", + "ui_playeroverlay_desc": "When you hover over a country, the Player info overlay appears. It shows the player type (Human, Nation, or Tribe), a Nation's attitude toward you (Hostile to Friendly), defending troops, gold, and the number of Warships and buildings they have.", "ui_wilderness": "Wilderness", - "option_pause": "Pause/Unpause the game - Only available in single player mode.", + "option_pause": "Pause/Unpause the game - Unavailable in public games.", + "option_speed": "Speed - Adjust the game speed. Unavailable in public games.", "option_timer": "Timer - Time passed since the start of the game.", "option_exit": "Exit button.", - "option_settings": "Settings - Open the settings menu. Inside you can toggle the Alternate view, Emojis, Dark Mode, Ninja (anonymous/random names mode), and action on left click.", + "option_settings": "Settings - Open the settings menu. Inside you can toggle things like Alternate view, Emojis, Dark Mode, Hidden names, action on left click and more.", "radial_title": "Radial menu", "radial_desc": "Right clicking (or touch on mobile) opens the Radial menu. Right click outside it to close it. From the menu you can:", "radial_build": "Open the Build menu.", diff --git a/src/client/HelpModal.ts b/src/client/HelpModal.ts index d70accd7e..b66336d9d 100644 --- a/src/client/HelpModal.ts +++ b/src/client/HelpModal.ts @@ -624,10 +624,11 @@ export class HelpModal extends BaseModal { ${translateText("help_modal.ui_options_desc")}

@@ -718,8 +719,7 @@ export class HelpModal extends BaseModal {
  • ${translateText("help_modal.radial_info")}
    • @@ -848,14 +848,11 @@ export class HelpModal extends BaseModal { ${translateText("help_modal.info_emoji")}
  • -
    - -
    + ${translateText("help_modal.info_trade")}