From bce27f1a6b666ce88c5ed118889fdc04dd5e07bb Mon Sep 17 00:00:00 2001 From: Evan Date: Tue, 14 Oct 2025 13:55:30 -0700 Subject: [PATCH] don't show ads if skin has been purchased, fixed ads not getting removed sometimes (#2196) ## Description: Now checks if player has any "pattern" flares and does not show ads. Also set visible=false when hiding ads, sometimes the ads were not getting destroyed properly. ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: evan --- src/client/GutterAds.ts | 1 + src/client/Main.ts | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/src/client/GutterAds.ts b/src/client/GutterAds.ts index f0f2f779f..b47f2939b 100644 --- a/src/client/GutterAds.ts +++ b/src/client/GutterAds.ts @@ -49,6 +49,7 @@ export class GutterAds extends LitElement { } public hide(): void { + this.isVisible = false; console.log("hiding GutterAds"); this.destroyAds(); this.requestUpdate(); diff --git a/src/client/Main.ts b/src/client/Main.ts index 37ae29027..2d61e78b6 100644 --- a/src/client/Main.ts +++ b/src/client/Main.ts @@ -350,6 +350,13 @@ class Client { "Sharing this ID will allow others to view your game history and stats.", ); this.patternsModal.onUserMe(userMeResponse); + const flares = (userMeResponse.player.flares ?? []).filter((flare) => + flare.startsWith("pattern:"), + ); + if (flares.length > 0) { + console.log("Hiding gutter ads because you have patterns"); + this.gutterAds.hide(); + } } };