Shrink the per-tick worker → main update payload by ~90% (#4244)

Stacked on #4243 (the `perf:client` harness) — first step of fixing the
every-100ms main-thread stutter: make the per-tick burst small before
spreading what remains across frames.

## Problem

The harness showed the main-thread burst was dominated by
`structuredClone` of the `updates` object, and the clone was dominated
by two kinds of per-tick churn that re-sent object payloads every tick:

- `gold` / `troops` / `tilesOwned` change for nearly every alive player
every tick → ~278 partial `PlayerUpdate` objects per tick (world/400
bots), ~508 on giantworldmap.
- Attack troop counts tick down every tick → whole
`outgoingAttacks`/`incomingAttacks` arrays re-cloned for every fighting
player every tick.
- `playerNameViewData` (an all-players record) was cloned every tick but
only recomputed every 30 ticks.

## Change

Three additions to the worker → main protocol (all transferable,
zero-clone):

1. **`packedPlayerUpdates`** — `[smallID, tilesOwned, gold, troops]`
float64 quads for players whose stats changed. These fields no longer
appear in `PlayerUpdate` diffs (first emissions still carry the full
snapshot). Gold is exact in a float64 (game values ≪ 2^53).
2. **`packedAttackUpdates`** — `[ownerSmallID, direction, index,
troops]` quads. Attack arrays are only resent when
membership/order/retreating changes — which is exactly the condition
that keeps the patch indexes valid (a tick either resends an array or
patches it, never both).
3. **`playerNameViewData` is now optional** — attached only on
placement-rebuild ticks (spawn ticks, first ticks, every 30th, spawn
end). The client keeps the last applied values; dead players' name
placements freeze at death (matching the previous effective behavior).

On the client, `GameView.populateFrame` now also rebuilds `names` /
`relationMatrix` / `allianceClusters` only when their inputs changed
that tick — field presence on a partial `PlayerUpdate` marks them dirty.
(`playerStatus`, nuke telegraphs, and attack rings still recompute every
tick; they're tick- or unit-dependent.)

## Results (perf:client, this machine; low-end devices ~5–20× slower)

Default run (world, 400 bots, 1800 ticks):

| stage | before | after |
|---|---|---|
| clone (serialize+deserialize) | 1.02ms | **0.09ms** |
| GameView.update | 0.62ms | **0.29ms** |
| WebGLFrameBuilder.update | 0.04ms | 0.04ms |
| **TOTAL burst mean** | **1.67ms** | **0.42ms** |
| TOTAL p99 / max | 3.47 / 10.3ms | **1.21 / 3.92ms** |

giantworldmap/600t: 2.54 → 0.68ms mean. Player update objects: 278 → 6.5
per tick (world), 508 → 12 (giant). The remaining burst is mostly tile
apply + per-tick derivations — the part that frame-spreading (next step)
addresses.

## Verification

- **Sim final hash unchanged** on all three reference configs
(`5607618202213430`, `29309648281599524`, `39945089450032050`) — no
simulation behavior change.
- **View hash unchanged** on all three configs (`942106e9`, `a3aae227`,
`cbaaf265`) — the rendered view state is provably identical
tick-for-tick, including the name-freeze semantics.
- New tests: `tests/PackedPlayerUpdates.test.ts` (drain + GameRunner
cadence), packed-channel and freeze-at-death cases in
`tests/client/view/GameView.test.ts`, `packAttackTroopDeltas` unit tests
and updated diff contract in `tests/GameUpdateUtils.test.ts` /
`tests/PlayerUpdateDiff.test.ts`.
- `npm test` (1490 tests), `eslint`, `prettier`, `tsc --noEmit` all
pass.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
Evan
2026-06-12 16:50:56 -07:00
committed by GitHub
parent 4149b3e4cb
commit bca980f572
16 changed files with 924 additions and 74 deletions
+70 -8
View File
@@ -72,10 +72,10 @@ describe("Player update diffing (toUpdate)", () => {
test("primitive changes appear in the diff without unchanged collections", () => {
alice.toUpdate();
alice.addGold(123n);
alice.markTraitor();
const diff = alice.toUpdate();
expect(diff).not.toBeNull();
expect(diff!.gold).toBe(alice.gold());
expect(diff!.isTraitor).toBe(true);
// Unchanged collection fields must be absent from the diff.
expect(diff!.allies).toBeUndefined();
expect(diff!.embargoes).toBeUndefined();
@@ -83,6 +83,52 @@ describe("Player update diffing (toUpdate)", () => {
expect(diff!.alliances).toBeUndefined();
});
test("stat churn (gold/troops/tilesOwned) travels via statsOut, not the diff", () => {
const statsOut: number[] = [];
alice.toUpdate(statsOut);
statsOut.length = 0;
alice.addGold(123n);
const diff = alice.toUpdate(statsOut);
// No object diff — gold alone must not put the player on the object
// channel (that's the whole point of the packed stats channel).
expect(diff).toBeNull();
expect(statsOut).toEqual([
alice.smallID(),
alice.numTilesOwned(),
Number(alice.gold()),
alice.troops(),
]);
// Nothing changed → no quad, no diff.
statsOut.length = 0;
expect(alice.toUpdate(statsOut)).toBeNull();
expect(statsOut).toEqual([]);
// A non-stat change produces an object diff but no quad.
alice.markTraitor();
expect(alice.toUpdate(statsOut)).not.toBeNull();
expect(statsOut).toEqual([]);
});
test("first emission carries the stats in the full snapshot, not statsOut", () => {
const info = new PlayerInfo(
"dora",
PlayerType.Human,
"dora_client",
"dora_id",
);
game.addPlayer(info);
const dora = game.player("dora_id");
const statsOut: number[] = [];
const full = dora.toUpdate(statsOut);
expect(full).not.toBeNull();
expect(full!.gold).toBe(dora.gold());
expect(full!.troops).toBe(dora.troops());
expect(full!.tilesOwned).toBe(dora.numTilesOwned());
expect(statsOut).toEqual([]);
});
test("adding and removing an embargo shows up in consecutive diffs", () => {
alice.toUpdate();
alice.addEmbargo(bob, false);
@@ -156,17 +202,33 @@ describe("Player update diffing (toUpdate)", () => {
alice.smallID(),
);
// As the attack progresses, troop counts change and must keep flowing
// through subsequent diffs.
// As the attack progresses, troop counts change — but attack arrays are
// NOT resent for troop-only changes. Troops flow as packed
// [ownerSmallID, direction, index, troops] quads instead.
game.drainPackedAttackUpdates(); // discard quads from earlier ticks
const nextUpdates = game.executeNextTick();
const nextPlayerUpdates = nextUpdates[
GameUpdateType.Player
] as PlayerUpdate[];
const next = nextPlayerUpdates.find((u) => u.id === "alice_id");
expect(next).toBeDefined();
expect(
next!.outgoingAttacks!.some((a) => a.targetID === bob.smallID()),
).toBe(true);
if (next !== undefined) {
// Alice may appear for other field changes, but not for attack arrays.
expect(next.outgoingAttacks).toBeUndefined();
}
const packed = game.drainPackedAttackUpdates();
expect(packed).not.toBeNull();
// Find alice's outgoing quads and check one matches her current attack.
const aliceQuads: number[][] = [];
for (let i = 0; i + 3 < packed!.length; i += 4) {
if (packed![i] === alice.smallID() && packed![i + 1] === 0) {
aliceQuads.push(Array.from(packed!.subarray(i, i + 4)));
}
}
expect(aliceQuads.length).toBeGreaterThan(0);
const aliceAttacks = alice.outgoingAttacks();
for (const [, , index, troops] of aliceQuads) {
expect(troops).toBe(aliceAttacks[index].troops());
}
});
test("in-worker mutation of shared empty collections fails loudly", () => {