mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-02 23:38:06 +00:00
Keybind Ground Attack (#1258)
## Description: - Implement ground attack logic in ClientGameRunner - Move cursor location logic from doBoatAttackUnderCursor to getTileUnderCursor for reusability. - New keybind G for Ground Attack - Add translations for ground attack labels in English ## Please complete the following: - [X] I have added screenshots for all UI updates - [X] I process any text displayed to the user through translateText() and I've added it to the en.json file - [X] I have added relevant tests to the test directory* - [X] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [X] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors <img width="902" alt="image" src="https://github.com/user-attachments/assets/54bb3178-af2e-4715-bfa2-82b7fe0e8e85" /> *The getTileUnderCursor() and doGroundAttackUnderCursor() methods are private with many dependencies. I did not do isolated unit testing and thus zero tests where added. ## Please put your Discord username so you can be contacted if a bug or regression is found: eng.la --------- Co-authored-by: evanpelle <evanpelle@gmail.com>
This commit is contained in:
@@ -416,6 +416,15 @@ export class UserSettingModal extends LitElement {
|
||||
@change=${this.handleKeybindChange}
|
||||
></setting-keybind>
|
||||
|
||||
<setting-keybind
|
||||
action="groundAttack"
|
||||
label=${translateText("user_setting.ground_attack")}
|
||||
description=${translateText("user_setting.ground_attack_desc")}
|
||||
defaultKey="KeyG"
|
||||
.value=${this.keybinds["groundAttack"] ?? ""}
|
||||
@change=${this.handleKeybindChange}
|
||||
></setting-keybind>
|
||||
|
||||
<div class="text-center text-white text-base font-semibold mt-5 mb-2">
|
||||
${translateText("user_setting.zoom_controls")}
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user