Fix remaining errors and enable strict mode (#1628)

## Description:

#1075 

Fixing all remaining type errors caused by strict mode and enable it.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I have read and accepted the CLA agreement (only required once).

## Please put your Discord username so you can be contacted if a bug or
regression is found:

azlod

---------

Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>
This commit is contained in:
Antoine
2025-08-04 01:06:31 +02:00
committed by GitHub
parent 7eb1bf732d
commit ad2598361b
18 changed files with 63 additions and 43 deletions
+5 -12
View File
@@ -29,7 +29,7 @@ async function nearbyUnits(
unitPosX: number,
rangeCheck: number,
range: number,
unitTypes: UnitType[],
unitTypes: readonly UnitType[],
) {
const game = await setup(mapName, { infiniteGold: true, instantBuild: true });
const grid = new UnitGrid(game.map());
@@ -51,7 +51,7 @@ describe("Unit Grid range tests", () => {
["plains", 0, 10, 11, false], // Exactly 1px outside
["big_plains", 0, 198, 42, true], // Inside huge range
["big_plains", 0, 198, 199, false], // Exactly 1px outside huge range
];
] as const;
describe("Is unit in range", () => {
test.each(hasUnitCases)(
@@ -77,25 +77,18 @@ describe("Unit Grid range tests", () => {
["plains", 0, 10, 11, [UnitType.DefensePost], 0], // 1px outside
["big_plains", 0, 198, 42, [UnitType.TradeShip], 1], // Inside huge range
["big_plains", 0, 198, 199, [UnitType.TransportShip], 0], // 1px outside
];
] as const;
describe("Retrieve all units in range", () => {
test.each(unitsInRangeCases)(
"on %p map, look if unit at position %p with a range of %p is in range of %p position, returns %p",
async (
mapName: string,
unitPosX: number,
range: number,
rangeCheck: number,
units: UnitType[],
expectedResult: number,
) => {
async (mapName, unitPosX, range, rangeCheck, units, expectedResult) => {
const result = await nearbyUnits(
mapName,
unitPosX,
rangeCheck,
range,
units,
units, // remove readonly
);
expect(result.length).toBe(expectedResult);
},