From a8836f76d33937dbf52f96af177d972f696eb0ee Mon Sep 17 00:00:00 2001
From: FloPinguin <25036848+FloPinguin@users.noreply.github.com>
Date: Wed, 4 Feb 2026 12:39:35 +0100
Subject: [PATCH] Reduce bot farming problem (#2895)

## Description:

Explanation of the bot farming strategy in the discord:
https://discord.com/channels/1359946986937258015/1359949371956789289/1460928540575928478
"the result is that a player can build unlimited factories for 125 000
gold discount, trade with themselves with each train being worth 50 000
gold. First the 25 000 for neutral trade and then another 25 000 when
the bot is harvested."
"If you have a minute and ally people around you it should be trivial to
get 10 of both cities and factories for 1.25mil"

It's debatable if we want to let people do that (close this PR) or see
it as an abusive mechanic.

Here is the fix, bots try to delete all structures now. You can simply
retake them to stop the deletion:


https://github.com/user-attachments/assets/ac1ca846-50bd-42fa-8e25-5ac25a6d627e

## Please complete the following:

- [X] I have added screenshots for all UI updates
- [X] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [X] I have added relevant tests to the test directory
- [X] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:

FloPinguin

Co-authored-by: Ryan <7389646+ryanbarlow97@users.noreply.github.com>
---
 src/core/execution/BotExecution.ts | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/core/execution/BotExecution.ts b/src/core/execution/BotExecution.ts
index 4f9f178f9..85fabb34a 100644
--- a/src/core/execution/BotExecution.ts
+++ b/src/core/execution/BotExecution.ts
@@ -1,7 +1,8 @@
-import { Execution, Game, Player } from "../game/Game";
+import { Execution, Game, isStructureType, Player } from "../game/Game";
 import { PseudoRandom } from "../PseudoRandom";
 import { simpleHash } from "../Util";
 import { AllianceExtensionExecution } from "./alliance/AllianceExtensionExecution";
+import { DeleteUnitExecution } from "./DeleteUnitExecution";
 import { AiAttackBehavior } from "./utils/AiAttackBehavior";
 
 export class BotExecution implements Execution {
@@ -58,6 +59,7 @@ export class BotExecution implements Execution {
     }
 
     this.acceptAllAllianceRequests();
+    this.deleteAllStructures();
     this.maybeAttack();
   }
 
@@ -80,6 +82,14 @@ export class BotExecution implements Execution {
     }
   }
 
+  private deleteAllStructures() {
+    for (const unit of this.bot.units()) {
+      if (isStructureType(unit.type()) && this.bot.canDeleteUnit()) {
+        this.mg.addExecution(new DeleteUnitExecution(this.bot, unit.id()));
+      }
+    }
+  }
+
   private maybeAttack() {
     if (this.attackBehavior === null) {
       throw new Error("not initialized");