mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-06-21 10:21:27 +00:00
ESLint improvements (#388)
## Description Adds various features to improve the DX with eslint: ### Webpack - Use `eslint-webpack-plugin` for better observability of lint errors during development. ### Ignored files - Enable `.gitignore` support for eslint. ### Commit hook - Add `eslint --fix` to pre-commit hook. ### Github actions - Add eslint check to a new github action workflow. - Use `eslint-formatter-gha` to annotate PR files with lint failures (see the Files changed tab, [example](https://github.com/openfrontio/OpenFrontIO/pull/388/commits/73862230be5aad7b18e122b1cd4ab05fc9570b2c)).  ## Testing These changes have been validated through local testing and through Github workflows. ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced - [x] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors ## Please put your Discord username so you can be contacted if a bug or regression is found: fake.neo --------- Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>
This commit is contained in:
@@ -0,0 +1,18 @@
|
||||
name: ESLint Check
|
||||
|
||||
on:
|
||||
pull_request:
|
||||
push:
|
||||
branches: [main]
|
||||
|
||||
jobs:
|
||||
eslint:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v4
|
||||
- uses: actions/setup-node@v4
|
||||
with:
|
||||
node-version: "20"
|
||||
cache: "npm"
|
||||
- run: npm ci
|
||||
- run: npx eslint --format gha
|
||||
Reference in New Issue
Block a user