From 3d3ad3ceced75c922612d1a3cd792535a6f91b71 Mon Sep 17 00:00:00 2001 From: Sajad Hashemian Date: Mon, 17 Feb 2025 00:38:40 +0100 Subject: [PATCH 1/2] add confirmation dialog before exiting the game --- src/client/graphics/layers/OptionsMenu.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/client/graphics/layers/OptionsMenu.ts b/src/client/graphics/layers/OptionsMenu.ts index 38c28af25..2e07e1e30 100644 --- a/src/client/graphics/layers/OptionsMenu.ts +++ b/src/client/graphics/layers/OptionsMenu.ts @@ -52,7 +52,11 @@ export class OptionsMenu extends LitElement implements Layer { private hasWinner = false; private onExitButtonClick() { - window.location.reload(); + const isConfirmed = confirm("Are you sure you want to exit the game?"); + + if (isConfirmed) { + window.location.reload(); + } } createRenderRoot() { From edac371b5555077b4f8bad10dcbe09ff82184b78 Mon Sep 17 00:00:00 2001 From: Sajad Hashemian Date: Mon, 17 Feb 2025 14:23:37 +0100 Subject: [PATCH 2/2] only display exit confirmation while player is alive --- src/client/graphics/layers/OptionsMenu.ts | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/client/graphics/layers/OptionsMenu.ts b/src/client/graphics/layers/OptionsMenu.ts index 2e07e1e30..32d07727a 100644 --- a/src/client/graphics/layers/OptionsMenu.ts +++ b/src/client/graphics/layers/OptionsMenu.ts @@ -52,11 +52,13 @@ export class OptionsMenu extends LitElement implements Layer { private hasWinner = false; private onExitButtonClick() { - const isConfirmed = confirm("Are you sure you want to exit the game?"); - - if (isConfirmed) { - window.location.reload(); + const isAlive = this.game.myPlayer()?.isAlive(); + if (isAlive) { + const isConfirmed = confirm("Are you sure you want to exit the game?"); + if (!isConfirmed) return; } + + window.location.reload(); } createRenderRoot() {