Nations send emoji when declining assistance requests (#1911)

Nations will now send emoji when declining assistance requests.

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

Cancel alliance requests if the recipient attacks (#1733)

Problem: attacking a player right before accepting an alliance request
is very effective since the requester can't fight back or reclaim his
territory without canceling the alliance and being penalized with the
traitor debuff.

Change:
- Attacking a player after he requested an alliance automatically
rejects the request
- No changes to existing attacks in both directions, only new attacks
affect the request

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I have read and accepted the CLA agreement (only required once).

regression is found:

IngloriousTom

src/client/graphics/layers/EmojiTable.ts

@@ -4,7 +4,7 @@ import { EventBus } from "../../../core/EventBus";
 import { AllPlayers } from "../../../core/game/Game";
 import { GameView, PlayerView } from "../../../core/game/GameView";
 import { TerraNulliusImpl } from "../../../core/game/TerraNulliusImpl";
-import { emojiTable, flattenedEmojiTable } from "../../../core/Util";
+import { Emoji, emojiTable, flattenedEmojiTable } from "../../../core/Util";
 import { CloseViewEvent, ShowEmojiMenuEvent } from "../../InputHandler";
 import { SendEmojiIntentEvent } from "../../Transport";
 import { TransformHandler } from "../TransformHandler";
@@ -42,7 +42,7 @@ export class EmojiTable extends LitElement {
         eventBus.emit(
           new SendEmojiIntentEvent(
             recipient,
-            flattenedEmojiTable.indexOf(emoji),
+            flattenedEmojiTable.indexOf(emoji as Emoji),
           ),
         );
         this.hideTable();

src/client/graphics/layers/PlayerPanel.ts

@@ -20,7 +20,7 @@ import {
 } from "../../../core/game/Game";
 import { TileRef } from "../../../core/game/GameMap";
 import { GameView, PlayerView } from "../../../core/game/GameView";
-import { flattenedEmojiTable } from "../../../core/Util";
+import { Emoji, flattenedEmojiTable } from "../../../core/Util";
 import { actionButton } from "../../components/ui/ActionButton";
 import "../../components/ui/Divider";
 import Countries from "../../data/countries.json";
@@ -218,12 +218,15 @@ export class PlayerPanel extends LitElement implements Layer {
         this.eventBus.emit(
           new SendEmojiIntentEvent(
             AllPlayers,
-            flattenedEmojiTable.indexOf(emoji),
+            flattenedEmojiTable.indexOf(emoji as Emoji),
           ),
         );
       } else {
         this.eventBus.emit(
-          new SendEmojiIntentEvent(other, flattenedEmojiTable.indexOf(emoji)),
+          new SendEmojiIntentEvent(
+            other,
+            flattenedEmojiTable.indexOf(emoji as Emoji),
+          ),
         );
       }
       this.emojiTable.hideTable();

src/client/graphics/layers/RadialMenuElements.ts

@@ -2,7 +2,7 @@ import { Config } from "../../../core/configuration/Config";
 import { AllPlayers, PlayerActions, UnitType } from "../../../core/game/Game";
 import { TileRef } from "../../../core/game/GameMap";
 import { GameView, PlayerView } from "../../../core/game/GameView";
-import { flattenedEmojiTable } from "../../../core/Util";
+import { Emoji, flattenedEmojiTable } from "../../../core/Util";
 import { renderNumber, translateText } from "../../Utils";
 import { BuildItemDisplay, BuildMenu, flattenedBuildTable } from "./BuildMenu";
 import { ChatIntegration } from "./ChatIntegration";
@@ -271,7 +271,7 @@ const infoEmojiElement: MenuElement = {
                 : params.selected;
             params.playerActionHandler.handleEmoji(
               targetPlayer!,
-              flattenedEmojiTable.indexOf(emoji),
+              flattenedEmojiTable.indexOf(emoji as Emoji),
             );
             params.emojiTable.hideTable();
           });