mirror of
https://github.com/openfrontio/OpenFrontIO.git
synced 2026-07-05 18:05:08 +00:00
Fix rebinded keys (#4175)
> **Before opening a PR:** discuss new features on [Discord](https://discord.gg/K9zernJB5z) first, and file bugs or small improvements as [issues](https://github.com/openfrontio/OpenFrontIO/issues/new/choose). You must be assigned to an `approved` issue — unsolicited PRs will be auto-closed. **Add approved & assigned issue number here:** Resolves #4174 ## Description: I have fixed the rebinding of the keys for the build menu modifier and the emoji menu modifier in the settings so that they actually work. And cleaned up the code ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory ## Please put your Discord username so you can be contacted if a bug or regression is found: tktk1234567
This commit is contained in:
@@ -505,22 +505,22 @@ export class UserSettingModal extends BaseModal {
|
||||
</h2>
|
||||
|
||||
<setting-keybind
|
||||
action="modifierKey"
|
||||
action="buildMenuModifier"
|
||||
label=${translateText("user_setting.build_menu_modifier")}
|
||||
description=${translateText("user_setting.build_menu_modifier_desc")}
|
||||
.defaultKey=${this.defaultKeybinds.modifierKey}
|
||||
.value=${this.getKeyValue("modifierKey")}
|
||||
.display=${this.getKeyChar("modifierKey")}
|
||||
.defaultKey=${this.defaultKeybinds.buildMenuModifier}
|
||||
.value=${this.getKeyValue("buildMenuModifier")}
|
||||
.display=${this.getKeyChar("buildMenuModifier")}
|
||||
@change=${this.handleKeybindChange}
|
||||
></setting-keybind>
|
||||
|
||||
<setting-keybind
|
||||
action="altKey"
|
||||
action="emojiMenuModifier"
|
||||
label=${translateText("user_setting.emoji_menu_modifier")}
|
||||
description=${translateText("user_setting.emoji_menu_modifier_desc")}
|
||||
.defaultKey=${this.defaultKeybinds.altKey}
|
||||
.value=${this.getKeyValue("altKey")}
|
||||
.display=${this.getKeyChar("altKey")}
|
||||
.defaultKey=${this.defaultKeybinds.emojiMenuModifier}
|
||||
.value=${this.getKeyValue("emojiMenuModifier")}
|
||||
.display=${this.getKeyChar("emojiMenuModifier")}
|
||||
@change=${this.handleKeybindChange}
|
||||
></setting-keybind>
|
||||
|
||||
|
||||
Reference in New Issue
Block a user