From 7dc5d472a79f41f921e840ef6c778d59195cd654 Mon Sep 17 00:00:00 2001 From: RickD004 Date: Fri, 15 May 2026 02:59:28 -0600 Subject: [PATCH] Change name of map "The Straits" into "Danish Straits" (#3929) ## Description: Renames TheStraits map. The people that suggested this map told me they would prefer a more specific name for the map, rather than the generic one it has right now. So im renaming it into Danish Straits This map is for v32, it has not been released, it should be fine to rename ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: tri.star1011 --- .../maps/{thestraits => danishstraits}/image.png | Bin .../maps/{thestraits => danishstraits}/info.json | 2 +- map-generator/main.go | 2 +- resources/lang/en.json | 2 +- .../{thestraits => danishstraits}/manifest.json | 2 +- .../maps/{thestraits => danishstraits}/map.bin | 0 .../maps/{thestraits => danishstraits}/map16x.bin | 0 .../maps/{thestraits => danishstraits}/map4x.bin | 0 .../{thestraits => danishstraits}/thumbnail.webp | Bin src/core/game/Game.ts | 4 ++-- src/server/MapPlaylist.ts | 2 +- 11 files changed, 7 insertions(+), 7 deletions(-) rename map-generator/assets/maps/{thestraits => danishstraits}/image.png (100%) rename map-generator/assets/maps/{thestraits => danishstraits}/info.json (98%) rename resources/maps/{thestraits => danishstraits}/manifest.json (99%) rename resources/maps/{thestraits => danishstraits}/map.bin (100%) rename resources/maps/{thestraits => danishstraits}/map16x.bin (100%) rename resources/maps/{thestraits => danishstraits}/map4x.bin (100%) rename resources/maps/{thestraits => danishstraits}/thumbnail.webp (100%) diff --git a/map-generator/assets/maps/thestraits/image.png b/map-generator/assets/maps/danishstraits/image.png similarity index 100% rename from map-generator/assets/maps/thestraits/image.png rename to map-generator/assets/maps/danishstraits/image.png diff --git a/map-generator/assets/maps/thestraits/info.json b/map-generator/assets/maps/danishstraits/info.json similarity index 98% rename from map-generator/assets/maps/thestraits/info.json rename to map-generator/assets/maps/danishstraits/info.json index 40cd3ce45..0265b811e 100644 --- a/map-generator/assets/maps/thestraits/info.json +++ b/map-generator/assets/maps/danishstraits/info.json @@ -1,5 +1,5 @@ { - "name": "thestraits", + "name": "Danish Straits", "nations": [ { "coordinates": [37, 227], diff --git a/map-generator/main.go b/map-generator/main.go index 03b1b323f..3e63fb394 100644 --- a/map-generator/main.go +++ b/map-generator/main.go @@ -43,6 +43,7 @@ var maps = []struct { {Name: "britanniaclassic"}, {Name: "caucasus"}, {Name: "conakry"}, + {Name: "danishstraits"}, {Name: "deglaciatedantarctica"}, {Name: "didier"}, {Name: "didierfrance"}, @@ -91,7 +92,6 @@ var maps = []struct { {Name: "svalmel"}, {Name: "taiwanstrait"}, {Name: "thebox"}, - {Name: "thestraits"}, {Name: "tourney1"}, {Name: "tourney2"}, {Name: "tourney3"}, diff --git a/resources/lang/en.json b/resources/lang/en.json index 17e26f5e4..af45bd6bf 100644 --- a/resources/lang/en.json +++ b/resources/lang/en.json @@ -510,7 +510,7 @@ "archipelagosea": "Archipelago Sea", "bajacalifornia": "Baja California", "taiwanstrait": "Taiwan Strait", - "thestraits": "The Straits", + "danishstraits": "Danish Straits", "northwestpassage": "Northwest Passage" }, "map_categories": { diff --git a/resources/maps/thestraits/manifest.json b/resources/maps/danishstraits/manifest.json similarity index 99% rename from resources/maps/thestraits/manifest.json rename to resources/maps/danishstraits/manifest.json index 87d9677fd..30d039b87 100644 --- a/resources/maps/thestraits/manifest.json +++ b/resources/maps/danishstraits/manifest.json @@ -14,7 +14,7 @@ "num_land_tiles": 142124, "width": 436 }, - "name": "thestraits", + "name": "Danish Straits", "nations": [ { "coordinates": [37, 227], diff --git a/resources/maps/thestraits/map.bin b/resources/maps/danishstraits/map.bin similarity index 100% rename from resources/maps/thestraits/map.bin rename to resources/maps/danishstraits/map.bin diff --git a/resources/maps/thestraits/map16x.bin b/resources/maps/danishstraits/map16x.bin similarity index 100% rename from resources/maps/thestraits/map16x.bin rename to resources/maps/danishstraits/map16x.bin diff --git a/resources/maps/thestraits/map4x.bin b/resources/maps/danishstraits/map4x.bin similarity index 100% rename from resources/maps/thestraits/map4x.bin rename to resources/maps/danishstraits/map4x.bin diff --git a/resources/maps/thestraits/thumbnail.webp b/resources/maps/danishstraits/thumbnail.webp similarity index 100% rename from resources/maps/thestraits/thumbnail.webp rename to resources/maps/danishstraits/thumbnail.webp diff --git a/src/core/game/Game.ts b/src/core/game/Game.ts index 97daeda67..0c71f4584 100644 --- a/src/core/game/Game.ts +++ b/src/core/game/Game.ts @@ -171,7 +171,7 @@ export enum GameMapType { BajaCalifornia = "Baja California", MiddleEast = "Middle East", TaiwanStrait = "Taiwan Strait", - TheStraits = "The Straits", + DanishStraits = "Danish Straits", NorthwestPassage = "Northwest Passage", } @@ -236,7 +236,7 @@ export const mapCategories: Record = { GameMapType.BajaCalifornia, GameMapType.MiddleEast, GameMapType.TaiwanStrait, - GameMapType.TheStraits, + GameMapType.DanishStraits, GameMapType.NorthwestPassage, ], fantasy: [ diff --git a/src/server/MapPlaylist.ts b/src/server/MapPlaylist.ts index 89eabaccc..99e7031ee 100644 --- a/src/server/MapPlaylist.ts +++ b/src/server/MapPlaylist.ts @@ -51,6 +51,7 @@ const FREQUENCY: Partial> = { Britannia: 5, Caucasus: 5, Conakry: 3, + DanishStraits: 5, DeglaciatedAntarctica: 4, Didier: 1, DidierFrance: 1, @@ -96,7 +97,6 @@ const FREQUENCY: Partial> = { Svalmel: 8, TaiwanStrait: 5, TheBox: 3, - TheStraits: 5, TradersDream: 4, TwoLakes: 6, World: 20,