From 75ca2fb349aa97146e651cb294a98171fb54a366 Mon Sep 17 00:00:00 2001 From: Aotumuri Date: Sat, 18 Oct 2025 06:39:33 +0900 Subject: [PATCH] Reduce redundant toggle strings to stay within Crowdin limits (#2219) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## Description: Purpose: to reduce redundant strings and avoid exceeding Crowdin’s text limit. - Replaced _enabled/_disabled text with shared ..._desc in SettingsModal.ts. スクリーンショット 2025-10-17 21 38 47 ## Please complete the following: - [x] I have added screenshots for all UI updates - [x] I process any text displayed to the user through translateText() and I've added it to the en.json file - [x] I have added relevant tests to the test directory - [x] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced ## Please put your Discord username so you can be contacted if a bug or regression is found: Aotumuri Co-authored-by: Evan --- resources/lang/en.json | 16 ---------- src/client/graphics/layers/SettingsModal.ts | 34 +++++---------------- 2 files changed, 8 insertions(+), 42 deletions(-) diff --git a/resources/lang/en.json b/resources/lang/en.json index 85bbae256..dfe6e0721 100644 --- a/resources/lang/en.json +++ b/resources/lang/en.json @@ -296,33 +296,21 @@ "tab_keybinds": "Keybinds", "dark_mode_label": "Dark Mode", "dark_mode_desc": "Toggle the site’s appearance between light and dark themes", - "dark_mode_enabled": "Dark mode enabled", - "light_mode_enabled": "Light mode enabled", "emojis_label": "Emojis", - "emojis_visible": "Emojis are visible", - "emojis_hidden": "Emojis are hidden", "emojis_desc": "Toggle whether emojis are shown in game", "alert_frame_label": "Alert Frame", "alert_frame_desc": "Toggle the alert frame. When enabled, the frame will be displayed when you are betrayed.", "special_effects_label": "Special effects", "special_effects_desc": "Toggle special effects. Deactivate to improve performances", - "special_effects_enabled": "Special effects enabled", - "special_effects_disabled": "Special effects disabled", "structure_sprites_label": "Structure Sprites", "structure_sprites_desc": "Toggle structure sprites", - "structure_sprites_enabled": "Structure Sprites enabled", - "structure_sprites_disabled": "Structure Sprites disabled", "anonymous_names_label": "Hidden Names", "anonymous_names_desc": "Hide real player names with random ones on your screen.", - "anonymous_names_enabled": "Anonymous names enabled", "lobby_id_visibility_label": "Hidden Lobby IDs", "lobby_id_visibility_desc": "Hide Lobby ID in private lobby creation", - "real_names_shown": "Real names shown", "left_click_label": "Left Click to Open Menu", "left_click_desc": "When ON, left-click opens menu and sword button attacks. When OFF, left-click attacks directly.", "left_click_menu": "Left Click Menu", - "left_click_opens_menu": "Left click opens menu", - "right_click_opens_menu": "Right click opens menu", "attack_ratio_label": "⚔️ Attack Ratio", "attack_ratio_desc": "What percentage of your troops to send in an attack (1–100%)", "troop_ratio_desc": "Adjust the balance between troops (for combat) and workers (for gold production) (1–100%)", @@ -330,8 +318,6 @@ "territory_patterns_desc": "Choose whether to display territory pattern designs in game", "performance_overlay_label": "Performance Overlay", "performance_overlay_desc": "Toggle the performance overlay. When enabled, the performance overlay will be displayed. Press shift-D during game to toggle.", - "performance_overlay_enabled": "Performance overlay enabled", - "performance_overlay_disabled": "Performance overlay disabled", "easter_writing_speed_label": "Writing Speed Multiplier", "easter_writing_speed_desc": "Adjust how fast you pretend to code (x1–x100)", "easter_bug_count_label": "Bug Count", @@ -389,8 +375,6 @@ "on": "On", "off": "Off", "toggle_terrain": "Toggle Terrain", - "terrain_enabled": "Terrain view enabled", - "terrain_disabled": "Terrain view disabled", "exit_game_label": "Exit Game", "exit_game_info": "Return to main menu", "background_music_volume": "Background Music Volume", diff --git a/src/client/graphics/layers/SettingsModal.ts b/src/client/graphics/layers/SettingsModal.ts index 2bfc57349..3956204f0 100644 --- a/src/client/graphics/layers/SettingsModal.ts +++ b/src/client/graphics/layers/SettingsModal.ts @@ -266,9 +266,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.toggle_terrain")}
- ${this.alternateView - ? translateText("user_setting.terrain_enabled") - : translateText("user_setting.terrain_disabled")} + ${translateText("user_setting.toggle_view_desc")}
@@ -288,9 +286,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.emojis_label")}
- ${this.userSettings.emojis() - ? translateText("user_setting.emojis_visible") - : translateText("user_setting.emojis_hidden")} + ${translateText("user_setting.emojis_desc")}
@@ -315,9 +311,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.dark_mode_label")}
- ${this.userSettings.darkMode() - ? translateText("user_setting.dark_mode_enabled") - : translateText("user_setting.light_mode_enabled")} + ${translateText("user_setting.dark_mode_desc")}
@@ -342,9 +336,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.special_effects_label")}
- ${this.userSettings.fxLayer() - ? translateText("user_setting.special_effects_enabled") - : translateText("user_setting.special_effects_disabled")} + ${translateText("user_setting.special_effects_desc")}
@@ -369,9 +361,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.structure_sprites_label")}
- ${this.userSettings.structureSprites() - ? translateText("user_setting.structure_sprites_enabled") - : translateText("user_setting.structure_sprites_disabled")} + ${translateText("user_setting.structure_sprites_desc")}
@@ -391,9 +381,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.anonymous_names_label")}
- ${this.userSettings.anonymousNames() - ? translateText("user_setting.anonymous_names_enabled") - : translateText("user_setting.real_names_shown")} + ${translateText("user_setting.anonymous_names_desc")}
@@ -413,9 +401,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.left_click_menu")}
- ${this.userSettings.leftClickOpensMenu() - ? translateText("user_setting.left_click_opens_menu") - : translateText("user_setting.right_click_opens_menu")} + ${translateText("user_setting.left_click_desc")}
@@ -440,11 +426,7 @@ export class SettingsModal extends LitElement implements Layer { ${translateText("user_setting.performance_overlay_label")}
- ${this.userSettings.performanceOverlay() - ? translateText("user_setting.performance_overlay_enabled") - : translateText( - "user_setting.performance_overlay_disabled", - )} + ${translateText("user_setting.performance_overlay_desc")}