alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-07-17 12:59:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Cut worker→main bandwidth ~3.3× by switching PlayerUpdate to deltas (#3967)

Browse Source 
## Description:

Cut worker→main bandwidth ~3.3× by switching PlayerUpdate from a full
per-tick snapshot to a field-level diff. PlayerImpl.toUpdate() now
caches the last sent update and returns only changed fields, or null if
nothing changed. The client-side applyStateUpdate() merges instead of
overwriting.

Per-tick total dropped from ~297 KB to ~89 KB; the Player bucket alone
went from 258 KB/tick to 50 KB/tick. Diff/apply logic lives in a new
GameUpdateUtils.ts module with unit tests.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:

evan
This commit is contained in:
Evan
2026-05-18 17:07:40 -07:00
committed by GitHub
parent ed928db081
commit 62e15d2794
9 changed files with 577 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/client/view/GameView.ts
+22 -13
View File
@@ -304,42 +304,51 @@ export class GameView implements GameMap {
// Pass 1: ensure every player exists with up-to-date PlayerState. We need
// all smallIDs registered before pass 2 can translate embargo PlayerIDs.
// PlayerUpdate is now partial: only `id` is guaranteed; everything else
// is present only when its value changed since the last emission.
gu.updates[GameUpdateType.Player].forEach((pu) => {
// First-emission (new player) — must have all static fields populated.
// Subsequent emissions for an existing player carry only changed fields.
const existing = this._players.get(pu.id);
// Replace the local player's name/displayName with their own stored values.
// This way the user does not know they are being censored.
if (pu.clientID === this._myClientID) {
// This way the user does not know they are being censored. clientID is
// static — present only on first emission — so this branch only runs once.
if (pu.clientID !== undefined && pu.clientID === this._myClientID) {
pu.name = this._myUsername;
pu.displayName = myDisplayName;
}
this.smallIDToID.set(pu.smallID, pu.id);
let player = this._players.get(pu.id);
if (player !== undefined) {
player.applyUpdate(pu);
if (pu.smallID !== undefined) {
this.smallIDToID.set(pu.smallID, pu.id);
}
if (existing !== undefined) {
existing.applyUpdate(pu);
const nextNameData = gu.playerNameViewData[pu.id];
if (nextNameData !== undefined) {
player.nameData = nextNameData;
existing.nameData = nextNameData;
}
} else {
player = new PlayerView(
const player = new PlayerView(
this,
pu,
gu.playerNameViewData[pu.id],
// First check human by clientID, then check nation by name.
this._cosmetics.get(pu.clientID ?? "") ??
this._cosmetics.get(pu.name) ??
this._cosmetics.get(pu.name!) ??
{},
);
this._players.set(pu.id, player);
this._playerStates.set(pu.smallID, player.state);
this._playerStates.set(pu.smallID!, player.state);
}
});
// Pass 2: translate engine embargoes (Set<PlayerID>) → renderer-format
// stringified smallIDs. We could do this only on changes, but embargo sets
// are typically small (<50 entries per player). Pass through all in case
// any pu in this tick referenced a player created in this same tick.
// smallIDs. Only re-translate when embargoes changed (field present);
// unchanged sets stay at the previously-computed renderer-format list.
gu.updates[GameUpdateType.Player].forEach((pu) => {
if (pu.embargoes === undefined) return;
const player = this._players.get(pu.id);
if (player === undefined) return;
const smallIDs: number[] = [];