Improve random spawn (#2503)

## Description:

This is a previously approved PR with an additional commit that fixes
case when nations change spawn & jump around, their previous territory
wasn't getting deleted.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

## Please put your Discord username so you can be contacted if a bug or
regression is found:

nikolaj_mykola

---------

Co-authored-by: Evan <evanpelle@gmail.com>

src/core/execution/utils/PlayerSpawner.ts

@@ -1,66 +1,14 @@
 import { Game, PlayerType } from "../../game/Game";
-import { TileRef } from "../../game/GameMap";
-import { PseudoRandom } from "../../PseudoRandom";
 import { GameID } from "../../Schemas";
-import { simpleHash } from "../../Util";
 import { SpawnExecution } from "../SpawnExecution";
 
 export class PlayerSpawner {
-  private random: PseudoRandom;
   private players: SpawnExecution[] = [];
-  private static readonly MAX_SPAWN_TRIES = 10_000;
-  private static readonly MIN_SPAWN_DISTANCE = 30;
 
   constructor(
     private gm: Game,
-    gameID: GameID,
-  ) {
-    this.random = new PseudoRandom(simpleHash(gameID));
-  }
-
-  private randTile(): TileRef {
-    const x = this.random.nextInt(0, this.gm.width());
-    const y = this.random.nextInt(0, this.gm.height());
-
-    return this.gm.ref(x, y);
-  }
-
-  private randomSpawnLand(): TileRef | null {
-    let tries = 0;
-
-    while (tries < PlayerSpawner.MAX_SPAWN_TRIES) {
-      tries++;
-
-      const tile = this.randTile();
-
-      if (
-        !this.gm.isLand(tile) ||
-        this.gm.hasOwner(tile) ||
-        this.gm.isBorder(tile)
-      ) {
-        continue;
-      }
-
-      let tooCloseToOtherPlayer = false;
-      for (const spawn of this.players) {
-        if (
-          this.gm.manhattanDist(spawn.tile, tile) <
-          PlayerSpawner.MIN_SPAWN_DISTANCE
-        ) {
-          tooCloseToOtherPlayer = true;
-          break;
-        }
-      }
-
-      if (tooCloseToOtherPlayer) {
-        continue;
-      }
-
-      return tile;
-    }
-
-    return null;
-  }
+    private gameID: GameID,
+  ) {}
 
   spawnPlayers(): SpawnExecution[] {
     for (const player of this.gm.allPlayers()) {
@@ -68,14 +16,7 @@ export class PlayerSpawner {
         continue;
       }
 
-      const spawnLand = this.randomSpawnLand();
-
-      if (spawnLand === null) {
-        // TODO: this should normally not happen, additional logic may be needed, if this occurs
-        continue;
-      }
-
-      this.players.push(new SpawnExecution(player.info(), spawnLand));
+      this.players.push(new SpawnExecution(this.gameID, player.info()));
     }
 
     return this.players;