Reapply graphics overrides on debug render GUI reset (#4287)

## Problem

The debug render GUI's **"Reset to Defaults"** restored bare
`createRenderSettings()` defaults, wiping the user's graphics overrides
(colorblind theme, ocean color, lighting, name scaling, etc.) from the
live render settings. The per-prop right-click "reset to default" and
the modified-indicators had the same flaw — their captured defaults were
raw, ignoring overrides.

## Fix

Thread the existing `resolveRenderSettings` (`createRenderSettings()` +
`applyGraphicsOverrides()`) into the debug GUI as the defaults provider,
so reset restores the same settings the renderer was actually built
with.

- **`debug/index.ts`** — added a `resolveDefaults` param (defaults to
`createRenderSettings` to keep the module decoupled). The captured
`defaults` now include overrides, fixing the per-prop reset and modified
indicators too.
- **`debug/Wiring.ts`** — `wireActions` takes `resolveDefaults`; the
reset handler `deepAssign`s `resolveDefaults()` instead of
`createRenderSettings()`.
- **`ClientGameRunner.ts`** — passes `resolveRenderSettings` into
`createDebugGui`, and extracts a `refreshDerivedGraphics` helper
(terrain rebuild + re-theme/palette) from `onGraphicsChanged`, wired as
the GUI's `onSettingsChanged` so the reapplied terrain/colorblind
overrides become *visible* after reset (they're baked into GPU textures
and aren't picked up per-frame).

Side benefit: editing terrain/theme settings in the debug GUI now
refreshes those textures live too (that callback was previously never
wired).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Evan
2026-06-14 19:44:20 -07:00
committed by GitHub
parent 094aa766ce
commit 5be72db060
3 changed files with 23 additions and 9 deletions
+3 -2
View File
@@ -1,6 +1,6 @@
import GUI, { FunctionController } from "lil-gui";
import type { RenderSettings } from "../RenderSettings";
import { createRenderSettings, dumpSettings } from "../RenderSettings";
import { dumpSettings } from "../RenderSettings";
import { deepAssign } from "../SettingsUtils";
import type { ConfigProp } from "./ConfigProp";
@@ -66,6 +66,7 @@ export function wireActions(
gui: GUI,
settings: RenderSettings,
props: ConfigProp[],
resolveDefaults: () => RenderSettings,
onSettingsChanged?: () => void,
): void {
gui.add({ dump: () => dumpSettings(settings) }, "dump").name("Download JSON");
@@ -99,7 +100,7 @@ export function wireActions(
.add(
{
reset: () => {
deepAssign(settings, createRenderSettings());
deepAssign(settings, resolveDefaults());
props.forEach((p) => p.resetToDefault());
onSettingsChanged?.();
},