From 57de2418aa066e28390fcd2725a80f9f327250f7 Mon Sep 17 00:00:00 2001
From: VariableVince <24507472+VariableVince@users.noreply.github.com>
Date: Fri, 3 Apr 2026 03:41:04 +0200
Subject: [PATCH] Turn around true/false for better readability

---
 src/server/MapPlaylist.ts        | 4 ++--
 src/server/MasterLobbyService.ts | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/server/MapPlaylist.ts b/src/server/MapPlaylist.ts
index 4d1a8d2b6..3e9e96f15 100644
--- a/src/server/MapPlaylist.ts
+++ b/src/server/MapPlaylist.ts
@@ -151,7 +151,7 @@ export class MapPlaylist {
 
   public async gameConfigNotInUse(
     type: PublicGameType,
-    isInUse: (config: GameConfig) => boolean,
+    notInUse: (config: GameConfig) => boolean,
   ): Promise<GameConfig> {
     const maxAttempts = 6;
     let attempts = 0;
@@ -161,7 +161,7 @@ export class MapPlaylist {
       const config = await this.buildConfig(type, map);
       attempts++;
 
-      if (!isInUse(config) || attempts >= maxAttempts) {
+      if (notInUse(config) || attempts >= maxAttempts) {
         this.consumeNextMap(type);
         return config;
       }
diff --git a/src/server/MasterLobbyService.ts b/src/server/MasterLobbyService.ts
index c8596df1c..e3cdbc16e 100644
--- a/src/server/MasterLobbyService.ts
+++ b/src/server/MasterLobbyService.ts
@@ -177,20 +177,20 @@ export class MasterLobbyService {
       }
 
       const gameConfig = await this.playlist.gameConfigNotInUse(type, (c) => {
-        if (usedMaps.has(c.gameMap)) return true;
+        if (usedMaps.has(c.gameMap)) return false;
 
         if (
           c.playerTeams !== undefined &&
           usedTeamTypes.has(String(c.playerTeams))
         ) {
-          return true;
+          return false;
         }
 
         if (c.maxPlayers !== undefined && usedMaxPlayers.has(c.maxPlayers)) {
-          return true;
+          return false;
         }
 
-        return false;
+        return true;
       });
 
       recordInUse(gameConfig);