Fix various ESLint violations (#402)

## Description:

Fixes a number of ESLint violations. Although I have tested these
changes through the local dev server, I don't have a high confidence
that the testing is sufficient, as I am new to this codebase. This
change would benefit from heightened scrutiny.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

fake.neo

---------

Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>

src/server/GameServer.ts

@@ -456,7 +456,7 @@ export class GameServer {
 
     const lastHashTurn = this.turns.length - 10;
 
-    let { mostCommonHash, outOfSyncClients } =
+    const { mostCommonHash, outOfSyncClients } =
       this.findOutOfSyncClients(lastHashTurn);
 
     if (outOfSyncClients.length == 0) {
@@ -464,11 +464,6 @@ export class GameServer {
       return;
     }
 
-    if (outOfSyncClients.length >= Math.floor(this.activeClients.length / 2)) {
-      // If half clients out of sync assume all are out of sync.
-      outOfSyncClients = this.activeClients;
-    }
-
     const serverDesync = ServerDesyncSchema.safeParse({
       type: "desync",
       turn: lastHashTurn,
@@ -519,7 +514,7 @@ export class GameServer {
     }
 
     // Create a list of clients whose hash doesn't match the most common one
-    const outOfSyncClients: Client[] = [];
+    let outOfSyncClients: Client[] = [];
 
     for (const client of this.activeClients) {
       if (client.hashes.has(turnNumber)) {
@@ -530,6 +525,11 @@ export class GameServer {
       }
     }
 
+    // If half clients out of sync assume all are out of sync.
+    if (outOfSyncClients.length >= Math.floor(this.activeClients.length / 2)) {
+      outOfSyncClients = this.activeClients;
+    }
+
     return {
       mostCommonHash,
       outOfSyncClients,

src/server/Gatekeeper.ts

@@ -16,7 +16,7 @@ export interface Gatekeeper {
   // The wrapper for request handlers with optional rate limiting
   httpHandler: (
     limiterType: LimiterType,
-    fn: (req: Request, res: Response, next: NextFunction) => Promise<any>,
+    fn: (req: Request, res: Response, next: NextFunction) => Promise<unknown>,
   ) => (req: Request, res: Response, next: NextFunction) => Promise<void>;
 
   // The wrapper for WebSocket message handlers with rate limiting
@@ -67,8 +67,8 @@ async function getGatekeeper(): Promise<Gatekeeper> {
       // Use dynamic import for ES modules
       // Using a type assertion to avoid TypeScript errors for optional modules
       const module = await import(
-        "./gatekeeper/RealGatekeeper.js" as any
-      ).catch(() => import("./gatekeeper/RealGatekeeper.js" as any));
+        "./gatekeeper/RealGatekeeper.js" as string
+      ).catch(() => import("./gatekeeper/RealGatekeeper.js" as string));
 
       if (!module || !module.RealGatekeeper) {
         console.log(
@@ -95,7 +95,7 @@ export class GatekeeperWrapper implements Gatekeeper {
 
   httpHandler(
     limiterType: LimiterType,
-    fn: (req: Request, res: Response, next: NextFunction) => Promise<any>,
+    fn: (req: Request, res: Response, next: NextFunction) => Promise<unknown>,
   ) {
     return async (req: Request, res: Response, next: NextFunction) => {
       try {
@@ -129,7 +129,7 @@ export class NoOpGatekeeper implements Gatekeeper {
   // Simple pass-through with no rate limiting
   httpHandler(
     limiterType: LimiterType,
-    fn: (req: Request, res: Response, next: NextFunction) => Promise<any>,
+    fn: (req: Request, res: Response, next: NextFunction) => Promise<unknown>,
   ) {
     return async (req: Request, res: Response, next: NextFunction) => {
       try {

src/server/MasterMetrics.ts

@@ -50,7 +50,7 @@ export function setupMetricsServer() {
         } else if (line.trim() && !line.startsWith("#")) {
           // Add worker label to each metric line and collect for later
           const processedLine = line.replace(
-            /^([a-z][a-z0-9_]*)(?:{([^}]*)})?(\s+[0-9\.e+-]+.*)/,
+            /^([a-z][a-z0-9_]*)(?:{([^}]*)})?(\s+[0-9.e+-]+.*)/,
             (match, metricName, existingLabels, valueAndRest) => {
               if (existingLabels) {
                 return `${metricName}{${existingLabels},worker="master"}${valueAndRest}`;
@@ -108,7 +108,7 @@ export function setupMetricsServer() {
               // Process and collect actual metric values
               try {
                 const processedLine = line.replace(
-                  /^([a-z][a-z0-9_]*)(?:{([^}]*)})?(\s+[0-9\.e+-]+.*)/,
+                  /^([a-z][a-z0-9_]*)(?:{([^}]*)})?(\s+[0-9.e+-]+.*)/,
                   (match, metricName, existingLabels, valueAndRest) => {
                     if (existingLabels) {
                       return `${metricName}{${existingLabels},worker="worker-${i}"}${valueAndRest}`;
@@ -122,7 +122,7 @@ export function setupMetricsServer() {
                 if (processedLine !== line) {
                   allMetricValues.push(processedLine);
                 } else if (
-                  line.match(/^[a-z][a-z0-9_]*(?:{[^}]*})?\s+[0-9\.e+-]+.*/)
+                  line.match(/^[a-z][a-z0-9_]*(?:{[^}]*})?\s+[0-9.e+-]+.*/)
                 ) {
                   // This looks like a metric line but didn't match our regex, try a more general approach
                   const parts = line.split(/({|\s+)/);

src/server/StructuredLog.ts

@@ -3,7 +3,13 @@ import { ClientID, GameID, LogSeverity } from "../core/Schemas";
 export interface slogMsg {
   logKey: string;
   msg: string;
-  data?: any;
+  data?: {
+    stack?: unknown;
+    clientID?: unknown;
+    clientIP?: unknown;
+    gameID?: unknown;
+    isRejoin?: unknown;
+  };
   severity?: LogSeverity;
   gameID?: GameID;
   clientID?: ClientID;