Fix various ESLint violations (#402)

## Description:

Fixes a number of ESLint violations. Although I have tested these
changes through the local dev server, I don't have a high confidence
that the testing is sufficient, as I am new to this codebase. This
change would benefit from heightened scrutiny.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

fake.neo

---------

Co-authored-by: Scott Anderson <662325+scottanderson@users.noreply.github.com>
This commit is contained in:
Scott Anderson
2025-04-02 21:06:08 -04:00
committed by GitHub
parent 77a60d5a00
commit 52f64db6d3
21 changed files with 127 additions and 126 deletions
-1
View File
@@ -40,7 +40,6 @@ export function createRenderer(
const startingModal = document.querySelector(
"game-starting-modal",
) as GameStartingModal;
startingModal instanceof GameStartingModal;
startingModal.hide();
// TODO maybe append this to dcoument instead of querying for them?
+1 -1
View File
@@ -216,7 +216,7 @@ export class StructureLayer implements Layer {
private handleUnitRendering(unit: UnitView) {
const unitType = unit.constructionType() ?? unit.type();
let iconType = unitType;
const iconType = unitType;
if (!this.isUnitTypeSupported(unitType)) return;
const config = this.unitConfigs[unitType];
+4 -3
View File
@@ -12,11 +12,12 @@ import { Layer } from "./Layer";
// Add this at the top of your file
declare global {
interface Window {
adsbygoogle: any[];
adsbygoogle: unknown[];
}
}
// Add this at the top of your file
declare let adsbygoogle: any[];
declare let adsbygoogle: unknown[];
@customElement("win-modal")
export class WinModal extends LitElement implements Layer {
@@ -257,7 +258,7 @@ export class WinModal extends LitElement implements Layer {
});
}
renderLayer(context: CanvasRenderingContext2D) {}
renderLayer(/* context: CanvasRenderingContext2D */) {}
shouldTransform(): boolean {
return false;