alois/OpenFrontIO
1
0
Fork 0
mirror of https://github.com/openfrontio/OpenFrontIO.git synced 2026-06-21 11:10:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Added two checkboxes to the default pull request template (#930)

Browse Source 
## Description:

Add the following checks to the pull request template : 
- [ ] I have added relevant tests to the test directory
- [ ] I process any text displayed to the user through translateText()
and i've added it to the en.json file/i

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I have added relevant tests to the test directory
- [x] I process any text displayed to the user through translateText()
and i've added it to the en.json file
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

theodoreleon.aetarax
This commit is contained in:
Théodore Léon
2025-05-29 05:01:51 +02:00
committed by GitHub
parent 1167ac80d7
commit 4443459bc5
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/PULL_REQUEST_TEMPLATE.md
+2
View File
@@ -3,6 +3,8 @@
## Please complete the following:
- [ ] I have added screenshots for all UI updates
- [ ] I process any text displayed to the user through translateText() and I've added it to the en.json file
- [ ] I have added relevant tests to the test directory
- [ ] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
- [ ] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors
.github/workflows/pr-description.yml
+3 -1
View File
@@ -24,9 +24,11 @@ jobs:
errors.push('❌ Missing or short `## Description:` section.');
}
// Check all three boxes are checked
// Check all five boxes are checked
const requiredBoxes = [
/- \[x\] I have added screenshots for all UI updates/i,
/- \[x\] I process any text displayed to the user through translateText\(\) and I\'ve added it to the en\.json file/i,
/- \[x\] I have added relevant tests to the test directory/i,
/- \[x\] I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced/i,
/- \[x\] I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors/i
];