From 0d1769fc920f661309eaf3d412506f77ad8e7eef Mon Sep 17 00:00:00 2001 From: scamiv <6170744+scamiv@users.noreply.github.com> Date: Thu, 4 Dec 2025 16:36:57 +0100 Subject: [PATCH] Refactor GameImpl and GameView methods to remove unnecessary return statements - Updated setOwnerID, setDefended, forEachTile, and setFallout methods in GameImpl and GameView to eliminate redundant return statements --- src/core/game/GameImpl.ts | 6 +++--- src/core/game/GameView.ts | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/core/game/GameImpl.ts b/src/core/game/GameImpl.ts index 95eff4123..abc424db5 100644 --- a/src/core/game/GameImpl.ts +++ b/src/core/game/GameImpl.ts @@ -863,7 +863,7 @@ export class GameImpl implements Game { return this._map.hasOwner(ref); } setOwnerID(ref: TileRef, playerId: number): void { - return this._map.setOwnerID(ref, playerId); + this._map.setOwnerID(ref, playerId); } hasFallout(ref: TileRef): boolean { return this._map.hasFallout(ref); @@ -874,7 +874,7 @@ export class GameImpl implements Game { } setDefended(ref: TileRef, value: boolean): void { - return this._map.setDefended(ref, value); + this._map.setDefended(ref, value); } isBorder(ref: TileRef): boolean { return this._map.isBorder(ref); @@ -898,7 +898,7 @@ export class GameImpl implements Game { return this._map.terrainType(ref); } forEachTile(fn: (tile: TileRef) => void): void { - return this._map.forEachTile(fn); + this._map.forEachTile(fn); } manhattanDist(c1: TileRef, c2: TileRef): number { return this._map.manhattanDist(c1, c2); diff --git a/src/core/game/GameView.ts b/src/core/game/GameView.ts index 4d7cdd900..11f48c88c 100644 --- a/src/core/game/GameView.ts +++ b/src/core/game/GameView.ts @@ -846,13 +846,13 @@ export class GameView implements GameMap { return this._map.hasOwner(ref); } setOwnerID(ref: TileRef, playerId: number): void { - return this._map.setOwnerID(ref, playerId); + this._map.setOwnerID(ref, playerId); } hasFallout(ref: TileRef): boolean { return this._map.hasFallout(ref); } setFallout(ref: TileRef, value: boolean): void { - return this._map.setFallout(ref, value); + this._map.setFallout(ref, value); } isDefended(ref: TileRef): boolean { @@ -860,7 +860,7 @@ export class GameView implements GameMap { } setDefended(ref: TileRef, value: boolean): void { - return this._map.setDefended(ref, value); + this._map.setDefended(ref, value); } isBorder(ref: TileRef): boolean { return this._map.isBorder(ref); @@ -884,7 +884,7 @@ export class GameView implements GameMap { return this._map.terrainType(ref); } forEachTile(fn: (tile: TileRef) => void): void { - return this._map.forEachTile(fn); + this._map.forEachTile(fn); } manhattanDist(c1: TileRef, c2: TileRef): number { return this._map.manhattanDist(c1, c2);