From 01ed6e70bcad9dea401161ad2d08aecb5617f3b0 Mon Sep 17 00:00:00 2001
From: Scott Anderson <662325+scottanderson@users.noreply.github.com>
Date: Mon, 14 Apr 2025 21:11:47 -0400
Subject: [PATCH] AllianceRequestReplyExecution

---
 .../alliance/AllianceRequestReplyExecution.ts         | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/core/execution/alliance/AllianceRequestReplyExecution.ts b/src/core/execution/alliance/AllianceRequestReplyExecution.ts
index 6a3b34e23..3c6bdc5e7 100644
--- a/src/core/execution/alliance/AllianceRequestReplyExecution.ts
+++ b/src/core/execution/alliance/AllianceRequestReplyExecution.ts
@@ -3,8 +3,8 @@ import { Execution, Game, Player, PlayerID } from "../../game/Game";
 
 export class AllianceRequestReplyExecution implements Execution {
   private active = true;
-  private requestor: Player;
-  private recipient: Player;
+  private requestor: Player | null = null;
+  private recipient: Player | null = null;
 
   constructor(
     private requestorID: PlayerID,
@@ -32,13 +32,16 @@ export class AllianceRequestReplyExecution implements Execution {
   }
 
   tick(ticks: number): void {
+    if (this.requestor === null || this.recipient === null) {
+      throw new Error("Not initialized");
+    }
     if (this.requestor.isFriendly(this.recipient)) {
       consolex.warn("already allied");
     } else {
       const request = this.requestor
         .outgoingAllianceRequests()
-        .find((ar) => ar.recipient() == this.recipient);
-      if (request == null) {
+        .find((ar) => ar.recipient() === this.recipient);
+      if (request === undefined) {
         consolex.warn("no alliance request found");
       } else {
         if (this.accept) {